Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO layout for VIA #295

Open
wants to merge 4 commits into
base: wireless_playground
Choose a base branch
from

Conversation

Mhilkos
Copy link

@Mhilkos Mhilkos commented Aug 19, 2024

Description

Added ISO keyboard layout for Keychron V6 Max to be used on VIA as a JSON file.
(I later realized that this is in the keychron website, but not in the repository. It would be nice if the maintainer of this branch could either add my commit or the one in the website to the repo, Thanks 👍🏻 )

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Implemented support for ISO keyboard layouts on VIA
Fixed key color on the JSON which made the keyboard layout look irrational on VIA (The keys were del, end and page down)
Changed 5, 18 to 5, 17.
Changed "4, 13" to "4, 12"
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Oct 27, 2024
@github-actions github-actions bot removed the stale label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant