Add some caching strategies explanation in readme #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevinrob
requested changes
Oct 3, 2018
| @@ -45,6 +45,43 @@ $stack->push(new CacheMiddleware(), 'cache'); | |||
| $client = new Client(['handler' => $stack]); | |||
| ``` | |||
|
|
|||
| # Caching strategies | |||
|
|
|||
| ## Public and private | |||
There was a problem hiding this comment.
Can you add a note about the respect of the RFC-7234 https://tools.ietf.org/html/rfc7234
| Theses two strategies automatically respects `Cache-Control` headers containing: | ||
| * `no-cache`, `no-store`: response won't be cached | ||
| * `max-age`: response will be cached for the corresponding time | ||
| It will also honor the `Expires` header will the corresponding TTL. |
|
|
||
| ## Public and private | ||
| Theses two strategies automatically respects `Cache-Control` headers containing: | ||
| * `no-cache`, `no-store`: response won't be cached |
There was a problem hiding this comment.
It's more complicated than that 😄
From the RFC:
5.2.1.4. no-cache
The "no-cache" request directive indicates that a cache MUST NOT use
a stored response to satisfy the request without successful
validation on the origin server.
Maybe this paragraph should explain that we try to respect the RFC.
|
I close this PR because there is not any change since 6 months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly basic but helps understanding the differences (at least).
Relates to #42.