Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a good documentation #42

Open
Kevinrob opened this issue Feb 14, 2016 · 8 comments
Open

Write a good documentation #42

Kevinrob opened this issue Feb 14, 2016 · 8 comments

Comments

@Kevinrob
Copy link
Owner

No description provided.

@andrefelipe
Copy link

Hi Kevin, thanks for the library, I am using in production just fine!

When you have time, could you write an example on how to implement the Flysystem cache? I tried but couldn't figure out how. I am new into this.

Thanks again! BTW I have you referenced here in Orchestrate library https://github.com/andrefelipe/orchestrate-php#cache-middleware

@Kevinrob
Copy link
Owner Author

@andrefelipe Hi, thank you for using it!
I will do that ASAP ;)

@Raffaello
Copy link

Hi,

can I even point that the example given for the public cache seems wrong?

the code example should use the PublicCacheStrategy instead is using like the private one PrivateCacheStrategy.

Or what's the diffrerence between PrivateCacheStrategy and Public One?
(anyway it is enough to read the comment in the code :)

thank you.

Kevinrob added a commit that referenced this issue Apr 14, 2016
@Kevinrob
Copy link
Owner Author

Hi @Raffaello, you're right!

The difference is about privacy and cache headers. Public cache will not cache something marked as Cache-Control: private. One good explication here.

@Kevinrob
Copy link
Owner Author

@andrefelipe I have added an example for Flysystem in the README. Sorry for taking some time to do it!

@andrefelipe
Copy link

Hey @Kevinrob thank you very much! Interesting to see the possibility to cache in S3 buckets. Not sure the IO delay will pay off, but great to have the possibility.

@bogdanghervan
Copy link

Good job on this beautifully designed package!

After a bit of poking around I found out that the caching strategy I really need is GreedyCacheStrategy and I think this should be documented as well in the README. In fact, I composer-required this package expecting it to do just that - cache every Guzzle request regardless of any cache-related recommendation in the response.

My use case is this: I'm writing a Goutte-based web scraper and I need to cache Guzzle responses for a reasonable amount of time.

@afoeder
Copy link
Contributor

afoeder commented May 2, 2017

@bogdanghervan : #80

magnetik added a commit to magnetik/guzzle-cache-middleware that referenced this issue Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants