Minor updates per reviewer's comments.

KevinGitonga · Aug 23, 2023 · ef34293 · ef34293
1 parent 0eb896c
commit ef34293
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/...rc/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt b/...rc/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt
@@ -82,7 +82,7 @@ class AdministratorControlsActivity :
       PROFILE_LIST_FRAGMENT
     }
     profileId = savedInstanceState?.extractCurrentUserProfileId()
-      ?: ProfileId.newBuilder().apply { internalId = -1 }.build()
+      ?: ProfileId.newBuilder().setInternalId(-1).build()
     administratorControlsActivityPresenter.handleOnCreate(
       extraControlsTitle,
       lastLoadedFragment,

diff --git a/app/src/main/java/org/oppia/android/app/profile/AdminPinActivityPresenter.kt b/app/src/main/java/org/oppia/android/app/profile/AdminPinActivityPresenter.kt
@@ -117,7 +117,7 @@ class AdminPinActivityPresenter @Inject constructor(
               AdminAuthEnum.PROFILE_ADMIN_CONTROLS.value -> {
                 activity.startActivity(
                   AdministratorControlsActivity.createAdministratorControlsActivityIntent(
-                    context, activity.intent.extractCurrentUserProfileId()
+                    context, profileId
                   )
                 )
                 activity.finish()
@@ -129,7 +129,7 @@ class AdminPinActivityPresenter @Inject constructor(
                     activity.intent.getIntExtra(
                       ADMIN_PIN_COLOR_RGB_EXTRA_KEY, -10710042
                     ),
-                    activity.intent.extractCurrentUserProfileId()
+                    profileId
                   )
                 )
                 activity.finish()

diff --git a/...src/main/java/org/oppia/android/app/settings/profile/ProfileEditDeletionDialogFragment.kt b/...src/main/java/org/oppia/android/app/settings/profile/ProfileEditDeletionDialogFragment.kt
@@ -53,7 +53,7 @@ class ProfileEditDeletionDialogFragment : InjectableDialogFragment() {
         dialog.dismiss()
       }
       .setPositiveButton(R.string.profile_edit_delete_dialog_positive) { dialog, _ ->
-        profileEditDialogInterface.deleteProfileByInternalProfileId(profileId)
+        profileEditDialogInterface.deleteProfileByProfileId(profileId)
       }
       .create()
     return alertDialog

diff --git a/app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditDialogInterface.kt b/app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditDialogInterface.kt
@@ -6,5 +6,5 @@ import org.oppia.android.app.model.ProfileId
 interface ProfileEditDialogInterface {
 
   /** Handles profile deletion in [ProfileEditFragment]. */
-  fun deleteProfileByInternalProfileId(profileId: ProfileId)
+  fun deleteProfileByProfileId(profileId: ProfileId)
 }
diff --git a/app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt b/app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt
@@ -61,7 +61,7 @@ class ProfileEditFragment :
     )
   }
 
-  override fun deleteProfileByInternalProfileId(profileId: ProfileId) {
+  override fun deleteProfileByProfileId(profileId: ProfileId) {
     profileEditFragmentPresenter.deleteProfile(profileId)
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,7 +61,7 @@ class ProfileEditFragment : @@
         )
       }
-      override fun deleteProfileByInternalProfileId(profileId: ProfileId) {
+      override fun deleteProfileByProfileId(profileId: ProfileId) {
         profileEditFragmentPresenter.deleteProfile(profileId)
       }
@@ Expand Down @@