Allow --dry-run with check command as long as --repair is not specified.

emborg/command.py

@@ -398,6 +398,8 @@ def run(cls, command, args, settings, options):
         verify = ["--verify-data"] if cmdline["--verify-data"] else []
         repair = ['--repair'] if cmdline['--repair'] else []
         if repair:
+            if 'dry-run' in options:
+                raise Error(f"--dry-run is not available with check command.")
             os.environ['BORG_CHECK_I_KNOW_WHAT_I_AM_DOING'] = 'YES'
 
         # identify archive or archives to check
@@ -453,6 +455,8 @@ def run(cls, command, args, settings, options):
         borg_opts = []
         if cmdline["--progress"] or settings.show_progress:
             borg_opts.append("--progress")
+        if 'dry-run' in options:
+            raise Error(f"--dry-run is not available with compact command.")
 
         # run borg
         borg = settings.run_borg(
@@ -883,7 +887,7 @@ def run(cls, command, args, settings, options):
 
         try:
             # compact the repository if requested
-            if settings.compact_after_delete:
+            if settings.compact_after_delete and not 'dry-run' in options:
                 narrate("Compacting repository ...")
                 compact = CompactCommand()
                 compact_status = compact.run("compact", [], settings, options)

emborg/emborg.py

@@ -81,10 +81,6 @@
 
 # Globals {{{1
 borg_commands_with_dryrun = "create delete extract prune upgrade recreate".split()
-dangerous_borg_commands_without_dryrun = "check compact"
-    # The commands that modify the repository and do not support --dry-run.
-    # When specifying --dry-run user expects to be safe.  These commands may not
-    # be safe.  Refuse to run if user requests --dry-run on these commands.
 set_shlib_prefs(use_inform=True, log_cmd=True, encoding=DEFAULT_ENCODING)
 
 # Utilities {{{1
@@ -532,11 +528,8 @@ def borg_options(self, cmd, borg_opts, emborg_opts, strip_prefix):
             emborg_opts.append("verbose")
         if "verbose" in emborg_opts:
             borg_opts.append("--verbose")
-        if "dry-run" in emborg_opts:
-            if cmd in borg_commands_with_dryrun:
-                borg_opts.append("--dry-run")
-            elif cmd in dangerous_borg_commands_without_dryrun:
-                raise Error(f"--dry-run is not available with {cmd} command.")
+        if "dry-run" in emborg_opts and cmd in borg_commands_with_dryrun:
+            borg_opts.append("--dry-run")
 
         if cmd == "create":
             if "verbose" in emborg_opts and "--list" not in borg_opts: