[feature/160-desserts-patchDessert] 상품 수정 API에서 새로운 옵션 추가 가능하도록 수정 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoongHyun-Kim
requested review from
sojungpp,
chaerlo127 and
psyeon1120
as code owners
sojungpp
reviewed
May 21, 2023
Comment on lines
+223
to
+226
| if (optionDTO.getOptionIdx() == null) { // 새로운 option인 경우 | ||
| PostDessertReq.Option newOption = new PostDessertReq.Option(optionDTO.getOptionDescription(), optionDTO.getOptionPrice()); | ||
| saveOption(newOption, dessert); | ||
| } else { // 이미 존재하는 option인 경우 |
There was a problem hiding this comment.
주석으로 설명 달아줘서 로직 알아보기 넘 좋네유 ,,🫶 수고해써 !!!
sojungpp
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 이슈 번호
#160
💬 기타 사항