Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump globwalk dep to 0.9 #886

Closed
wants to merge 1 commit into from
Closed

Bump globwalk dep to 0.9 #886

wants to merge 1 commit into from

Conversation

Gilnaa
Copy link

@Gilnaa Gilnaa commented Dec 23, 2023

Bumps globwalk to version 0.9, mostly to get rid of bitflags 1.* transitive dependecy. (see Gilnaa/globwalk#34)

@Gilnaa
Copy link
Author

Gilnaa commented Dec 25, 2023

It looks like ignore 0.4.21 has a much higher MSRV due to the new use of OnceLock. (available since Rust 1.70.0)
This doesn't look a regression that is related to this PR, (this can be reproduced by checking-out an older version of globwalk and running cargo +1.65.0 check).

Not sure what to make of it, honestly.


It's possible to explicitly mention ignore = "<=0.4.20" in tera's Cargo.toml, and it would technically make this test pass, but will limit tera's users to an old version of ignore until the constraint is removed; possibly causing conflicts with other crates.
Is there a best-practice I'm missing?

@Keats
Copy link
Owner

Keats commented Dec 28, 2023

It's the problem of having a MSRV, in practice it can change at any point without a direct dependency update :/
In practice I think I will just wait for v2 to upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants