-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added config option for specifying cacheKey namespace #84
base: master
Are you sure you want to change the base?
Conversation
Can you check #56? It seems similar and there was some discussion about such feature there. |
Also you created #83 with the same name - if it's a duplicate too, please close one of them. |
We have two uses for this
Overal this solution is less complicated than #56 and optional, you dont have to use it. We tried Redis partitioning but it proved much too complicated to configure and use on daily basis. Also I did not implement RedisLua version because Lua is not my friend and in high trafic applications we are experiencing issues with journal locking, but we were unable to pinpoint where problem is. |
Just to be clear I just wanted to point you to the related issue but I won't work on this. My role in Kdyby is mainly merging bugfixes or small features. I won't merge this since it's not a bug-fix and also because Filip was reluctant to include similar feature in #56. You will have to ask him. |
I would consider this a valid use-case, but you can just as easily just run 100s of instances of redis and it would take almost no additional RAM. Even without docker, just start it on different ports. This would also make your testing environment better, since it would increase the isolation level of separate application instances.
This use-case has been addressed in #56 (comment)
It's a bit less complicated - yes. The implementation in #56 is also optional. I still think my arguments against namespacing the keys are very relevant. This is a highly power-user feature. Since you can really easily shoot yourself in the foot with this. I'm not sure what to do. |
You can configure cache namespace.
Examples: