-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/docker: Install fewer packages with --no-install-recommends #77
base: master
Are you sure you want to change the base?
Conversation
@@ -30,18 +30,17 @@ jobs: | |||
sudo apt update | |||
sudo apt remove -y firefox | |||
sudo apt upgrade -y | |||
sudo apt install -y \ | |||
sudo apt install -y --no-install-recommends \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition won't make much difference here, but it doesn't seem to harm anything.
When building the docker image though, there's some nice savings:
Before
65 Summary:
7.165 Upgrading: 0, Installing: 346, Removing: 0, Not Upgrading: 0
7.165 Download size: 673 MB
7.165 Space needed: 3240 MB / 146 GB available
After
#6 6.604 Summary:
#6 6.604 Upgrading: 0, Installing: 279, Removing: 0, Not Upgrading: 0
#6 6.604 Download size: 563 MB
#6 6.604 Space needed: 2568 MB / 30.0 GB available
https://github.com/KaruroChori/vs-fltk/actions/runs/12506343689/job/34891143298#step:7:484
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea. I would actually go as far as avoiding to upgrade dependencies if not strictly needed to be honest, the time it wastes is just too much.
Do you know if there is any good reason why we should not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried that a couple times. Sometimes it works, but other times what happens is 404 errors when the packages in the existing package lists are no longer available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, that usually happens on ubuntu/debian not when one does not upgrade, but without update.
In theory it should be possible to only perform apt update
and not get the 404 errors.
I will be experimenting with that as well in a separate branch :)
4cf76d6
to
ad74fb3
Compare
No description provided.