Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes #166

Open
wants to merge 5 commits into
base: development-v3
Choose a base branch
from
Open

Quick fixes #166

wants to merge 5 commits into from

Conversation

BanCrash
Copy link
Contributor

@BanCrash BanCrash commented Sep 12, 2021

NOTE: Since this won't get merged, you will have to manually replace the modified files. You only have to get the files that are modified on the "dist" folder, and you have to think that "dist" = "your Lauhdutin main folder". So, for example, if you want to replace dist/@Resources/main/init.lua you will have to replace the file in Lauhdutin/@Resources/main/init.lua.

NOTE 2: Dist folder doesn't contain all necessary files for the skin to work, so if you want to make a fresh install you have first to download the last beta release and then paste the contents of "dist" folder inside the beta folder.

Each commit says what is changed, so feel free to only get the changes do you want to get added.

Changelog (so far):

  • Fixed an issue with the detection of Steam libraries with the last Steam version.
  • Fixed Steam is running detection
  • Added save the last sort state, to start the skin with the last sorted state (for example last played) instead of the default state.

FYI @humanspida @Nathipha

@humanspida
Copy link

humanspida commented Sep 12, 2021

I've chosen to fork your version of the skin so I can more easily see when changes and updates are made with a glance at the commits at the top of the repo. Then I can either go straight to your repo to check it out and get the update or fetch and merge upstream to update my repo and then download the updated files from there.
I'm assuming your master version has all these changes implemented, right?

Cheers for keeping the project alive - I'm happy to do some testing if/when needed as well.

@BanCrash
Copy link
Contributor Author

I've chosen to fork your version of the skin so I can more easily see when changes and updates are made with a glance at the commits at the top of the repo. Then I can either go straight to your repo to check it out and get the update or fetch and merge upstream to update my repo and then download the updated files from there.

Cheers for keeping the project alive - I'm happy to do some testing if/when needed as well.

Don't expect a lot of changes soon. I've been working like three years ago from time to time on a modification of the original Lauhdutin, but it's still a WIP with more bugs than the original (I've focused on features rather than on stability) and it's not ready to be published yet.

You should check the quickFixes branch, I will add any change we discussed here on that branch.

@BanCrash
Copy link
Contributor Author

@humanspida no, my master branch is not updated. You have to check the quickFixes branch ;)

@humanspida
Copy link

Ahh OK.
What would be the best way to integrate the changes from your quick fixes branch into my master?
Although I joined github some time ago, I'm still pretty new to the system.

@BanCrash
Copy link
Contributor Author

Ahh OK.
What would be the best way to integrate the changes from your quick fixes branch into my master?
Although I joined github some time ago, I'm still pretty new to the system.

With a Pull request:

image

@humanspida
Copy link

OK, think I got the two the wrong way round or did I?

@BanCrash
Copy link
Contributor Author

OK, think I got the two the wrong way round or did I?

Yep, but you solved fast haha ;)

@matty62385
Copy link

Hi, im experiencing the same issues as humanspida, and i would like to do what he has done since it fixed it for him. Issue is, i have no clue what i am doing, since ive never used github before. Ive tried using humanspida's fork, but when i run the settings or main .inis i get:
rainmeter_helpers.lua:152: Failed to write to "C:\Users\Admin\Documents\Rainmeter\Skins\dist@Resources\Languages\English.txt"
As this didn't work, I have also created my own master, and created a pull request like in the image a few comments above... and thats as far as ive got. Im assuming ive got to approve the pull request, but i really just dont know what im doing, so if you could give me some help i would greatly appreciate it :) . Thanks!

@matty62385
Copy link

Ok, just for a little more information, ive checked the directory stated in the error message, and there doesnt seem to even be a folder in @resources called Languages, so thats where the error is coming from, the files i got off humanspida's fork were possibly incomplete.

@matty62385
Copy link

Okay, another update. I found out how to merge the pull request to my own master, downloaded the files via github desktop like i did with humanspida's files, transferred the 'dist' folder into my rainmeter skins folder, and... i got the same issue, that there doesn't seem to be any Languages folder : /

@humanspida
Copy link

humanspida commented Sep 12, 2021

I made this mistake myself.
What you need to do is get the latest Beta4 release from the releases page and then you can take the init.lua from resources\main\platforms\steam in the updated files online and drop that into the same folder locally in your rainmeter Lauhdutin folder to replace the one thats there right now.

The repo itself isnt a release and lacks some files that are needed for rainmeter to run the skin

@BanCrash
Copy link
Contributor Author

Okay, another update. I found out how to merge the pull request to my own master, downloaded the files via github desktop like i did with humanspida's files, transferred the 'dist' folder into my rainmeter skins folder, and... i got the same issue, that there doesn't seem to be any Languages folder : /

You have to download the last beta release from this repository and follow the readme instructions. After that, get the dist files and paste them on the skin path, replacing the existing files.

@humanspida
Copy link

humanspida commented Sep 12, 2021

You dont necessarily need the whole repo yourself, unless you want it of course, it's just that one init.lua file from the steam folder that needs replacing in your local Rainmeter\Skins\Lauhdutin\Resources\Main\Platforms\Steam folder once you have the Beta4 release installed.

Since you've already cloned my updated repo or merged the changes from BanCrash's Quick Fixes repo into your own - you can just download your repo as a zipfile and copy the init.lua from the dist\Resources\Main\Platforms\Steam folder into your local one.

Restart Rainmeter and load the skin, input your settings and refresh skin.
Should work at this point and start downloading the banners for you.

@matty62385
Copy link

thanks alot! ill try this in a few hours when i have some free time, but i think this all makes sense now. Thanks for the quick replies :)

@Nathipha
Copy link

Nathipha commented Sep 18, 2021

I updated Rainmeter to 4.5.2 (already got the 3.1.0 beta 4), edited both "init.lua" files (no idea how to actually download the files, tbh) and now my games are showing up again!

Thanks so much! :)

@BanCrash
Copy link
Contributor Author

I updated Rainmeter to 4.5.2 (already got the 3.1.0 beta 4), edited both "init.lua" files (no idea how to actually download the, tbh) and now my games are showing up again!

Thanks so much! :)

Glad to read that!

For some reason instead downloading my quickFixes branch it downloads my master branch, so I don't know how to download my quickFixes branch currently. Odd...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants