Skip to content

Train test val split #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Train test val split #34

wants to merge 3 commits into from

Conversation

ClaudiaWinklmayr
Copy link
Contributor

What is the purpose of this PR?

added the script to create the train-test-val spilt for arctique

How did you implement your changes?

How did you test your changes?

Remaining issues

Copy link

@jeromel05 jeromel05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small suggestions for reusability and readability of the code

@@ -0,0 +1,190 @@
{
"cells": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this as a python script rather than a Notebook, it would make it way easier to track changes

import shutil
import pandas as pd

orig_train_path = Path("/fast/AG_Kainmueller/data/patho_foundation_model_bench_data/arctique_dataset/original_data//v1-0/train") #Path("C:/Users/cwinklm/Documents/Data/v_review_sample10/train")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this in a run() function that is called with "if name == "main":"
Also, would be nice to use argparse to get the arguments like paths etc, this would make the script reusable if the data changes location, or if we want to adapt it to another dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants