Feature/search by clothes api #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foura1201
requested changes
Jan 13, 2024
feat: add fields to login api's response
foura1201
reviewed
Jan 13, 2024
src/controller/search/controller.ts
Outdated
Comment on lines
14
to
22
| const categoriesArray = Array.isArray(categories) | ||
| ? categories | ||
| : [categories].filter(Boolean); | ||
| const seasonsArray = Array.isArray(seasons) | ||
| ? seasons | ||
| : [seasons].filter(Boolean); | ||
|
|
||
| //text를 String type으로 | ||
| const textString = typeof text === 'string' ? text : ''; |
There was a problem hiding this comment.
이 부분 제가 코멘트를 잘못 달아뒀던 것 같습니다. 죄송합니다ㅜㅜ 요청으로 배열이 필요한 경우에는 쿼리보다 바디를 이용하는 것이 더 좋을 것 같습니다..ㅜ
isseul
reviewed
Jan 14, 2024
…EBofficial/stylevillage-server into feature/search-by-clothes-api
|
지금 검색어에 따른 검색결과는 잘 나오는 것 같은데 category, season,filter 반영이 잘 안되는 것 같습니다ㅜㅜ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res가 너무 길어서 직접 테스트 해보심이 좋을 듯 합니다.
categories : Category[]
seasons : Season[]
name : string
Body에 들어갈 수 있는 key입니다.