Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean #19

Closed
wants to merge 13 commits into from
Closed

Clean #19

wants to merge 13 commits into from

Commits on May 2, 2024

  1. Clean create_pkg_codemeta()

    - improve indentation
    - use cat() instead of print() with respect
      of the "dbg" variable (using new helper
      function cat_and_run() -> do not depend on
      the "glue" package
    - return early within lapply() function
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a8b9c99 View commit details
    Browse the repository at this point in the history
  2. Call create_codemeta() with the full path!

    Passing only the package name does not work
    (any more?)!
    
    Check for installed packages out of lapply()
    and improve the corresponding message
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ffeb750 View commit details
    Browse the repository at this point in the history
  3. Clean create_universe_pkgs_json()

    - improve indentation
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    43246ee View commit details
    Browse the repository at this point in the history
  4. Clean download_github()

    - improve indentation and spacing
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    075d6dd View commit details
    Browse the repository at this point in the history
  5. Clean get_gh_ratelimit()

    - improve indentation
    - use one pipe, together with selectElements()
      from kwb.utils
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a331582 View commit details
    Browse the repository at this point in the history
  6. Clean get_github_packages()

    - return early if ignore_pkgs is NULL
    - rename "ignore_condition" to "is_ignored"
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7bfcf7b View commit details
    Browse the repository at this point in the history
  7. Clean get_pkg_dependencies()

    - use intermediate variable "package_db"
    - use a magrittr pipe
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3ee0496 View commit details
    Browse the repository at this point in the history
  8. Extract get_pkg_dependencies_impl()

    and reuse this function in get_recursive_pkg_dependencies()
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8be066b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d96b7e5 View commit details
    Browse the repository at this point in the history
  10. Clean github_commits.R

    - improve indentation
    - use "L" to indicate integer
    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3a7efb6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f3bcd69 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    164241c View commit details
    Browse the repository at this point in the history
  13. Clean remaining files

    hsonne committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2bde353 View commit details
    Browse the repository at this point in the history