Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Courses #20

Open
wants to merge 12 commits into
base: gh-pages
Choose a base branch
from
Open

Courses #20

wants to merge 12 commits into from

Conversation

lorenzo-sani
Copy link
Collaborator

@willu47 I just updated the way courses are created using a front matter variable "course", writing it to the lectures and recalling it in the course page

@willu47
Copy link
Contributor

willu47 commented Apr 21, 2020

Hi @lorenzo-sani - looks like a good addition. There's a lot of conflicts here though. You need to follow these steps after a pull request happens:

git checkout gh-pages # change back to the gh-pages branch
git pull # pull down the latest changes
git checkout -b lorenzo/courses. # create and switch to a new branch

# Now do some work
git add <do some work>
git commit -m "Commit message"

# Push up the changes and submit a pull request
git push -u origin lorenzo/courses

This way, you ensure that your local copy of the repository never falls too far out of sync with the one on Github.

@willu47
Copy link
Contributor

willu47 commented Apr 21, 2020

You can also delete your old branch too:

git branch -d old_branch_name

The small -d is a "safe" delete - it will only remove the branch if Git knows that the commits on that branch have been merged in to the gh-pages (normally master branch)

@lorenzo-sani
Copy link
Collaborator Author

@willu47 thanks for the clarification and sorry for the mess 😅

@willu47
Copy link
Contributor

willu47 commented Apr 22, 2020

Hi Lorenzo - I see a number of duplicate lectures now - can you remove these?

Also, I'm not convinced of this automated route. Currently this is a middle ground between fully automatically generated course pages (generated from course: tags in the lectures) and fully manual courses - where a collection of course pages contain links to the lectures, and tags are not used.

The fully automatic route raises the issue of the order of the lectures. How do you define which lecture goes first, second, third etc. What if you wish to include a lecture in multiple courses?

In other words, I think the automatic generation is cool, but it raises more questions than it answers. I suggest we go for a manual approach. Perhaps add the functionality as an issue to keep a record (together with the code snippets) and we can revisit this at another point in time.

@lorenzo-sani
Copy link
Collaborator Author

Actually, using {% if lecture.course contains page.title%} allows for a lecture to be added to more than one course.
But I agree with the problem of deciding the order of the lectures, I hadn't thought it through.
I agree with removing that part for now and stick for the manual approach. However, I would maintain the course category since it could be useful in some other instances (for example creating the navigation bar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants