-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create build-iPA.yml to build iPA for iOS #971
Conversation
- Set AppIcon(same as Android) - Set to correct app name(Sptube -> Spotube) -
Excellent work. First of all, thanks for submitting the PR ❤️ Some changes are requested:
|
So there will be three flavors : nightly , dev , stable , right ? |
Yes, these are the 3 flavors.
|
Okay , I will add flavors first |
update working status now can build with flavors , next step RPReplay_Final1703953765.MP4 |
needs help for test
|
You'll need the following:
|
I only set two DOTENV , but seems it works, I pass android part so it failed . https://github.com/powenn/spotube/actions/workflows/spotube-release-binary.yml |
@KRTirtho I think it's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need build-iPA.yml anymore
@powenn Flavor support was added but the logo is still using the nightly version for every flavor. You can run without specifying the nightly config files for $ dart run flutter_launcher_icons
$ dart run flutter_native_splash:create |
What is the correct asset for each flavor icon Then what's the asset for dev icon |
The dev and stable icons are the same. Only the name are different in home screen. One is "Spotube Dev" other is just "Spotube" |
Tried the command provided , but didn't generate appicon assets , do I have to update some yaml config ? Solved in the latest commit , now dev and stable are using correct Appicon |
Awesome work! I guess it should work fine now. 😁 Thanks a lot for the contribution ❤️ |
It install and works fine except if the screen get locked the music stop playing. |
Trying to install this ipa with AltStore and getting |
Hi , I saw some discussions about providing iPA files for iOS sideloading , so this pull request was made for solving it .
Tested on TrollStore , video attach at bottom
link to download iPA
https://github.com/powenn/spotube/releases/tag/3.3.0
link to my build result
https://github.com/powenn/spotube/actions/runs/7361863281
Description
This pull request introduces a continuous integration (CI) workflow using GitHub Actions for building and packaging the Flutter iOS app into an IPA file. The workflow runs on macOS-latest and performs the following steps:
subosito/flutter-action
GitHub Action.Changes Made
.github/workflows/build-ipa.yml
for the GitHub Actions CI workflow.build_runner
, and build the iOS app.Additional Notes
is triggered on pushes, pull requests, andmanual runs usingworkflow_dispatch
.spotube.ipa
.RPReplay_Final1703931424.MP4