Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist/whitelist for keywords to be avoided/preferred from source names (such as "live" or "video") #730

Open
1 task done
BloodRaven0 opened this issue Sep 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@BloodRaven0
Copy link

BloodRaven0 commented Sep 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Pain

I often get lives or video streams that have bonus sound effects and non-music segments (that sponsorblock sometimes fails to skip), and that is because the default source for the songs is set to a live video.

Suggested solution

Let us have a blacklist for words that, if included in the source name, will be put at the bottom of the list (meaning, if there are no other sources, they will still be played)
Additionally, we could also have a whitelist that does the opposite, puts sources that contain the keyword at the top of the list.

For example, with a default blacklist of "live" and "video", and a whitelist of "lyric" and "audio", the automatic source selection would work better in most cases, and it will be customizable for people who have different preferences.

@BloodRaven0 BloodRaven0 added the enhancement New feature or request label Sep 18, 2023
@KRTirtho
Copy link
Owner

Does it makes sense to blacklist words?

What if a song has that word in it's title? It'll get ignored entirely causing the playback to break

Talking about whilelist it's already being done. Phrases like Official Audio or Official Lyrics Video or Official video etc are sorted to be first
And also there's YouTube's own search algorithm which returns the most matching result at top. So I'm not sure if it will be really helpful in this way

Btw, Spotube had this feature in some old versions. It had worse results than current

@BloodRaven0
Copy link
Author

I see. The way I imagined it would work is it would put all results containing the word at the bottom, so if no alternative tracks are available that don't contain the word, they would still get played.
It could create a problem that a different track from the same artist plays in its stead though, but it would be easily fixable by scrolling to the bottom.

Also may I ask that the whitelist feature be customizable? In particular I don't want "official video" to be whitelisted, because videos often have intros, outros and added sound effects that degrade the listening experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants