Add code documentation to new extension #46
Conversation
|
I fails to show the login widget in the showcase for me. I see in the console 10.000s of messages that say I'm using Chrome v116 and Node v18.16.1. Also, I added a Markdown linter to format the README. |
Thanks for adding that linter! I'm not able to replicate exactly your issue, if you try to open the showcase app when the extension is not installed, it will throw some errors. Also, if the extension has a general failure, the showcase was not really designed to catch those errors yet, so it might infinitely try to reach the mothership. These issues are often fixed by refreshing the extension (pressing update in the extensions page): 
Please let me know if this issue persists. |
|
It still doesn't work. |
Are you trying to log in with an identity created on solid playground which no longer exists? (created yesterday) |
No, I'm using my own WebID and pod. |
|
@rafael-mindreau I got it working. The |
Oh WOW! Good that you mention that, because I've totally forgotten about this. When I added this into the code, I suspected that this might not be static. I had an existential crisis trying to replicate this issue, so I'm glad you found it. I will add this into documentation! |
| * Queries for an IDP for a given WebID | ||
| * We use the IDPs generally for redirecting the user to the login/authorization flow of their IDP | ||
| * TODO: If your WebID does not exist or the IDP cannot be determined, this will fail with an error and no fallback | ||
| */ | ||
| async _getIDPsFromWebID(webId) { |
There was a problem hiding this comment.
I think this should happen by the extension. That way the extension always returns the IDP. This is not security concern, because this data is public in any case and there is not authentication happening at this point.
| @@ -28,10 +37,15 @@ export default class IdentityWidget { | |||
| console.log('%cDISCONNECT', 'padding: 5px; border-radius: 3px; background: #ff3333; font-weight: bold; color: white', 'Extension got disconnected, replenishing connections...'); | |||
| } | |||
|
|
|||
| // TODO: Long-lived connections will shut down after a longer period of inactivity. They are hydrated by opening the connection again after it is closed | |||
| // The idea is to only update the connection when it is absolutely needed | |||
| // Keep-alive mechanism TODO: check if there isn't a better way of handling this | |||
There was a problem hiding this comment.
Every TODO should have a issue linked to it.
- fix npm vulnerability - add documentation - pin extension id
…e-sentence lint rules, and fixed the resulting errors - removed prettier dependency - fixed unclear descriptions
|
Instead of merging, you need to push this code to |
Please comment on parts that are still not clear or need more clarification.