Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement sequences as macro in a module #967

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented May 12, 2024

No description provided.

@xs5871 xs5871 force-pushed the refactor-macros branch from cf32dbd to 07b8dad Compare May 13, 2024 10:51
@xs5871 xs5871 force-pushed the refactor-macros branch from b811ec3 to 6adb6be Compare May 20, 2024 08:46
@xs5871
Copy link
Collaborator Author

xs5871 commented May 20, 2024

Better macros. It's not super pretty, but it's good enough to be an improvement:

  • It's a module. No unecessary code in core.
  • Asynchronous. Doesn't lock the entire firmware, but it will buffer key events when a macro is running and replay them afterwards.
  • Clean Interface. No more awkward double negative no_press/no_release.
  • Unittestable.
  • Unintentionally flexible. Effectively any code can be put in a macro now.
  • Spellchecked documentation on the third try.

I'll purge the abomination that's the sequences code soonish. A couple of board configurations need refactoring, which I'm not looking forward to.

@xs5871 xs5871 marked this pull request as ready for review May 20, 2024 09:06
@xs5871
Copy link
Collaborator Author

xs5871 commented May 20, 2024

Sometimes clicking the right button is hard.

Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot!

@regicidalplutophage regicidalplutophage merged commit 3cc70ed into main Jun 1, 2024
3 checks passed
@regicidalplutophage regicidalplutophage deleted the refactor-macros branch June 1, 2024 18:13
@anventia
Copy link

It seems like the docs have not been updated, and still shows the old Sequences, can this please be updated?

@claycooper
Copy link
Member

New docs have been pushed to the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants