Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer tap interrupted #740

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix layer tap interrupted #740

merged 1 commit into from
Mar 16, 2023

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented Mar 13, 2023

resolves #739 and adds unit test for that scenario.

@regicidalplutophage
Copy link
Member

regicidalplutophage commented Mar 13, 2023

This only fixes case 1 where we press a non-holdtap key within the tap time of a LayerTap key.
Does not fix case 2 where we press a holdtap within the tap time of modtap: the output is still not layer shifted and both keys produce tap output.

@regicidalplutophage
Copy link
Member

The #741 is not what caused the problem in the second case, although not specifying tap_time changed output from tapped key to held key. The expected output is layer shifted key.

Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't fix layertap completely, but somewhat improves it. I think it can be merged for what it is.

@xs5871 xs5871 force-pushed the fix-layer-tap-interrupted branch from 4ce29ed to da999fa Compare March 15, 2023 08:22
@xs5871
Copy link
Collaborator Author

xs5871 commented Mar 15, 2023

How about now?

@regicidalplutophage
Copy link
Member

Nope, sorry

@xs5871
Copy link
Collaborator Author

xs5871 commented Mar 15, 2023

Did you set tap_interrupted=False? I tripple checked and all the unit tests and hardware testing show that it's working properly in any combination of scenarios.

@regicidalplutophage
Copy link
Member

I'm positive that this PR alone did not fix LayerTap + HoldTap scenario for me with keys being configured as:

TEST2 = KC.HT(KC.F, KC.MO(3), prefer_hold=True, tap_interrupted=True)
TEST3 = KC.HT(KC.F, KC.LSFT, prefer_hold=True, tap_interrupted=True)

In combination with #743 however, it works. #743 also seem to have resolved #741.

Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In combination with #743 resolves issues #739 and #741

@xs5871 xs5871 merged commit 26bf630 into master Mar 16, 2023
@xs5871 xs5871 deleted the fix-layer-tap-interrupted branch March 16, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tap_interrupted=True parameter does not work in context of LayerTap[BUG]
2 participants