-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layer tap interrupted #740
Conversation
This only fixes case 1 where we press a non-holdtap key within the tap time of a LayerTap key. |
The #741 is not what caused the problem in the second case, although not specifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't fix layertap completely, but somewhat improves it. I think it can be merged for what it is.
4ce29ed
to
da999fa
Compare
How about now? |
Nope, sorry |
Did you set |
I'm positive that this PR alone did not fix LayerTap + HoldTap scenario for me with keys being configured as:
In combination with #743 however, it works. #743 also seem to have resolved #741. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolves #739 and adds unit test for that scenario.