Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Reviung34 #687

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Added Reviung34 #687

merged 2 commits into from
Oct 17, 2023

Conversation

daysgobye
Copy link
Collaborator

Also created Gtips folder and put all of gtips's boards in said folder.

I have built and tested this keyboard with this code.

@xs5871
Copy link
Collaborator

xs5871 commented Feb 4, 2023

Since there hasn't been any progress: PR has to pass tests before any review.
@daysgobye, you're not a new contributer... we have this exact same discussion every single time.

@daysgobye daysgobye added the board addition/change Adds or modifies a keyboard, or MCU to a keyboard label Feb 5, 2023
@kdb424
Copy link
Contributor

kdb424 commented Oct 13, 2023

Looks like this can be closed as fixes are already in from #777

daysgobye and others added 2 commits October 17, 2023 09:16
…said folder

Apply updates and corrections for `Reviung34`

---------

Co-authored-by: xs5871 <[email protected]>
@xs5871 xs5871 merged commit d77c292 into master Oct 17, 2023
2 of 3 checks passed
@xs5871 xs5871 deleted the reviung34 branch October 17, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board addition/change Adds or modifies a keyboard, or MCU to a keyboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants