-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add permissive_hold option to holdtap #653
base: master
Are you sure you want to change the base?
Conversation
This adds a `permissive_hold` parameter to HoldTap keys that operates in the same fashion as the QMK option of the same name. See https://docs.qmk.fm/#/tap_hold?id=permissive-hold
Does this really work differently from prefer_hold parameter? |
Yes, in a way that makes home row mods significantly nicer to use. With prefer_hold, any rollover with a mod key whatsoever triggers the hold key. For example (stealing from the QMK docs):
With prefer_hold, this will use the layer 2 translation of KC_L, while with permissive_hold, it produces "al". From my own attempts at using it, prefer_hold is basically unusable with home row mods, since rollovers consistently produce accidental mod activations. I've been using Basically, permissive_hold allows me to get mod activation during holds less than the tap_time if and only if the modified key is tapped and released entirely before the modtap key is released, which is the exact functionality I'm looking for. Beyond this, I've been wondering if it wouldn't make sense to try and bring holdtap more in line with how QMK does modtap config. Beyond their extensive option set, the community that cares about modtap and home row mods seems entirely built around the configuration language that QMK uses. See https://precondition.github.io/home-row-mods. That conversation is obviously beyond the scope of this change, but the fact that this feature is present in QMK but not KMK is an annoyance that I'm already trying to solve. |
related to #436 Feature parity is always good and welcome. Copying QMKs terrible, confusing naming conventions and unintuitive default settings, not so much. |
This adds a
permissive_hold
parameter to HoldTap keys that operates in the same fashion as the QMK option of the same name.See https://docs.qmk.fm/#/tap_hold?id=permissive-hold