Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DiodeOrientation to columns_to_anodes mapping #1063

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix DiodeOrientation to columns_to_anodes mapping #1063

merged 1 commit into from
Dec 23, 2024

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented Dec 23, 2024

fixes #1059

regicidalplutophage
regicidalplutophage approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild.

@regicidalplutophage regicidalplutophage merged commit dbc2650 into main Dec 23, 2024
2 checks passed
@regicidalplutophage regicidalplutophage deleted the fix-diodeorientation branch December 23, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regicidalplutophage regicidalplutophage regicidalplutophage approved these changes

@claycooper claycooper Awaiting requested review from claycooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Matrix COL2ROW ROW2COL are swapped
2 participants
@xs5871 @regicidalplutophage