Fix sticky_keys hold release #1055
Conversation
|
@xs5871 Feel free to fix the aspell dictionary. I've no idea how it should be created or sorted -- the huge diff is because I saw that it was somewhat alphabetized, but apparently I alphabetized it too much. |
regicidalplutophage
changed the title
util/aspell.en.pws
Outdated
There was a problem hiding this comment.
@xs5871 Feel free to fix the aspell dictionary. I've no idea how it should be created or sorted -- the huge diff is because I saw that it was somewhat alphabetized, but apparently I alphabetized it too much.
It already was sorted alphabetically (A-Za-z, just like ASCII). It automatically sorts and increases the dictionary counter if you run utils/spellcheck.sh.
There was a problem hiding this comment.
Oh, OK. I'll run it locally then.
tests/test_sticky_keys.py
Outdated
| {}, | ||
| ], | ||
| ) | ||
|
|
There was a problem hiding this comment.
That already exists on line 114: stick, multiple interleaved other.
There was a problem hiding this comment.
Oh. Then that illustrates the another is pressed doc change.
While looking into this and trying to figure out why is unit test so unhappy with my solution I started to realize that
defer_releasenever worked right -- there had to be a reason I weren't using it on my own keyboard, despite on paper this is exactly how I want my sticky keys to behave.The unit test's new expected result to me is way more intuitive.