Refactor venv #1031
Merged
Refactor venv #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise spellcheck will search for example in `.venv` for typos in tooling packages. Maybe the search expression should be a positive list.
claycooper
approved these changes
Sep 28, 2024
util/spellcheck.sh
Outdated
| @@ -8,7 +8,7 @@ fi | |||
| ROOT=$(git rev-parse --show-toplevel) | |||
|
|
|||
| # This gets us only english .md files at the moment, but is clearly brittle | |||
| MARKDOWN_FILES=$(find "$ROOT" -name '*.md' -not -path '**/ptBR/**' -not -path '**/*-ptBR.md' -not -path '**/ja/**') | |||
| MARKDOWN_FILES=$(find "$ROOT" -name '*.md' -not -path '**/ptBR/**' -not -path '**/*-ptBR.md' -not -path '**/ja/**' -not -path '**/.*/**') | |||
There was a problem hiding this comment.
The lang paths could be removed here now that we've retired those paths.
There was a problem hiding this comment.
There was still one non-english doc hidden in hardware, that's why I didn't touch that part.
It's removed now. The "hardware" part of KMK isn't maintained anyway (and imo shouldn't be part of the firmware repository).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.toml.pipenvand use a plain venv instead.pipenvis just another point of failure, excruciatingly slow, requires seperate Pipfiles, and doesn't even add convenience since we're not building packages.