Feedback implementation for the Workshop #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Chinchilla <[email protected]> # Conflicts: # docs/develop/08_opendid/01_overview.md # docs/develop/08_opendid/02_opendid_flow.md # docs/develop/08_opendid/03_opendid_service.md # docs/develop/08_opendid/04_integrate_opendid.md # docs/develop/08_opendid/05_demo_project.md # docs/develop/08_opendid/06_advanced.md
|
@MarkusGarmeister Fixed merge conflicts, I think you started work before I made changes. Will now look at the code side. |
Signed-off-by: Chris Chinchilla <[email protected]>
code_examples/sdk_examples/src/workshop/attester/generateKeypairs.ts
Outdated
Show resolved
Hide resolved
|
Also seems to be a lot of text editor / IDE formatting differences in the PR, markdown doesn't really have standards, so I don't mind allowing these in, but they're not really necessary and someone else's changes will probably change them again. I use |
Signed-off-by: Chris Chinchilla <[email protected]>
|
@MarkusGarmeister Something is wrong with our CI tests, I ran them locally and everything worked OK, so will approve this now |
ChrisChinchilla
approved these changes
Jul 2, 2024
Signed-off-by: Chris Chinchilla <[email protected]>
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3455
I made several changes to improve the project:
Updated the JS code for ES6 compatibility:
-Added file extensions to the imported files.
-Changed the require statements to ES6 import syntax.
Added a generateKeypairs file to the attester module.
Included terminal commands for quick creation of folder structures and files.
Modified the output of the DID to make it less confusing.
Checklist: