Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the links and wording in setup of nodes #272

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

Dudleyneedham
Copy link
Member

fixes NO TICKET

Updated links

How to test:

Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)

  • Step 1
  • Step 2
  • etc.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the piece about wasm, and we're good.

We recommend aligning your nightly version with the one used in the [KILT node repository](https://github.com/KILTprotocol/kilt-node) by executing the [init script](https://github.com/KILTprotocol/kilt-node/blob/develop/scripts/init.sh).
After cloning the repository, you can build the executable by running the `build` command below from the root directory.

In order to build the KILT full node executable, you need to have [rustup and Rust installed](https://www.rust-lang.org/tools/install).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wasm32-unknown-unknown target is still required, so please add that piece back.

In order to build the KILT collator executable, you need to have a [nightly version of Rust](https://www.rust-lang.org/tools/install) and the `wasm32-unknown-unknown` target for this toolchain installed.
We recommend aligning your nightly version with the one used in the [KILT node repository](https://github.com/KILTprotocol/kilt-node) by executing the [init script](https://github.com/KILTprotocol/kilt-node/blob/develop/scripts/init.sh).
After cloning the repository, you can build the executable by running the `build` command below from the root directory.
In order to build the KILT full node executable, you need to have [rustup and Rust installed](https://www.rust-lang.org/tools/install).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-272.d3oeht7cvddn19.amplifyapp.com

@Dudleyneedham Dudleyneedham merged commit 8fa5073 into master Aug 22, 2023
6 checks passed
@Dudleyneedham Dudleyneedham deleted the dn-fix-broken-link branch August 22, 2023 09:36
Dudleyneedham added a commit that referenced this pull request Aug 22, 2023
* fix: update the links and wording in setup of nodes

* feat: adding ref to toolchain
Dudleyneedham added a commit that referenced this pull request Aug 22, 2023
* feat: cherry pick from previous pr

* feat: removal of the polkadot keyring adding kilt keyring

* feat: removal of the api as parameter and adding config serivce

* Apply suggestions from code review

Co-authored-by: Antonio <[email protected]>

* feat: adding connect to spirit peregrine

* feat: updating the typing to include kilt

* feat: removal of polkadot js submittable extrinisc

* feat: updating the staking

* feat: removal of polkadot js types

* fix: removing staking account

* fix: update the links and wording in setup of nodes (#272)

* fix: update the links and wording in setup of nodes

* feat: adding ref to toolchain

---------

Co-authored-by: Antonio <[email protected]>
Dudleyneedham added a commit that referenced this pull request Aug 22, 2023
* fix: update the links and wording in setup of nodes

* feat: adding ref to toolchain
Dudleyneedham added a commit that referenced this pull request Aug 22, 2023
* feat: cherry pick from previous pr

* feat: removal of the polkadot keyring adding kilt keyring

* feat: removal of the api as parameter and adding config serivce

* Apply suggestions from code review

Co-authored-by: Antonio <[email protected]>

* feat: adding connect to spirit peregrine

* feat: updating the typing to include kilt

* feat: removal of polkadot js submittable extrinisc

* feat: updating the staking

* feat: removal of polkadot js types

* fix: removing staking account

* fix: update the links and wording in setup of nodes (#272)

* fix: update the links and wording in setup of nodes

* feat: adding ref to toolchain

---------

Co-authored-by: Antonio <[email protected]>
Dudleyneedham added a commit that referenced this pull request Sep 29, 2023
* feat: cherry pick from previous pr

* feat: removal of the polkadot keyring adding kilt keyring

* feat: removal of the api as parameter and adding config serivce

* Apply suggestions from code review

Co-authored-by: Antonio <[email protected]>

* feat: adding connect to spirit peregrine

* feat: updating the typing to include kilt

* feat: removal of polkadot js submittable extrinisc

* feat: updating the staking

* feat: removal of polkadot js types

* fix: removing staking account

* fix: update the links and wording in setup of nodes (#272)

* fix: update the links and wording in setup of nodes

* feat: adding ref to toolchain

---------

Co-authored-by: Antonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants