mention peregrine in quickstart guide #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ntn-x2
approved these changes
Jul 25, 2023
|
|
||
| <Tabs groupId="ts-js-choice"> | ||
| <TabItem value='ts' label='Typescript' default> | ||
|
|
||
| From inside the `kilt-rocks` project directory, install the **KILT SDK**, **Ts-node**, **Axios** and **Typescript**: | ||
| From inside the `kilt-rocks` project directory, install the **KILT SDK**, **Typescript**, **ts-node** and **Axios**: |
There was a problem hiding this comment.
Should we then also change the order of the installation in the npm install command below?
| </SnippetBlock> | ||
|
|
||
| After establishing a connection, you have access to the chain, but let's not forget to **close** any connections when we are done! | ||
| Connections to blockchain nodes should be dropped when no longer needed: to do that simply call the `Kilt.disconnect()` function at the bottom of `main` function. | ||
| By adding `await Kilt.disconnect()` at the end of the main function, you ensure that the connection to the blockchain node is properly closed when the script finishes executing. |
There was a problem hiding this comment.
Suggested change
| By adding `await Kilt.disconnect()` at the end of the main function, you ensure that the connection to the blockchain node is properly closed when the script finishes executing. | |
| By adding `await Kilt.disconnect()` at the end of the main function, you ensure that the connection to the blockchain node is properly closed when the script terminates execution. |
| After establishing a connection, you have access to the chain, but let's not forget to **close** any connections when we are done! | ||
| Connections to blockchain nodes should be dropped when no longer needed: to do that simply call the `Kilt.disconnect()` function at the bottom of `main` function. | ||
| By adding `await Kilt.disconnect()` at the end of the main function, you ensure that the connection to the blockchain node is properly closed when the script finishes executing. | ||
| This helps maintain the integrity of your application and is a good practice to follow. |
There was a problem hiding this comment.
keeping the app state free from resource leaks which could lead to a crash. Integrity as in an unimpaired condition
docs/develop/01_sdk/01_quickstart.md
Outdated
| You have connected to a Spiritnet node. | ||
| Let's now start querying some data from the chain!** | ||
| Congratulations! | ||
| You have connected to a blockchain node. |
There was a problem hiding this comment.
maybe?
Suggested change
| You have connected to a blockchain node. | |
| You have connected to a KILT blockchain node. |
Dudleyneedham
pushed a commit
that referenced
this pull request
Jul 31, 2023
Dudleyneedham
pushed a commit
that referenced
this pull request
Aug 2, 2023
Dudleyneedham
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/2674