doc: w3n query #261
Merged
doc: w3n query #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ntn-x2
reviewed
Jul 18, 2023
| * **submitterAccount**: The keyring pair of the submitter. | ||
| * **signCallback**: The sign extrinsic callback function. This function is used to sign the extrinsic, read more that in [the SignCallback section](../07_signCallback.md). | ||
|
|
||
| The function `releaseWeb3Name` uses the KILT SDK to create a *web3name release transaction* using `api.tx.web3Names.releaseByOwner`. |
There was a problem hiding this comment.
Is this the right direction to go? We would not be able to catch any of these inconsistencies if the naming changes, at some point. What about adding comments to the code snippet directly?
There was a problem hiding this comment.
I think adding comments to the code make it less readable. e.g. hard to spot what is actually going on, finding the function calls in between all the comments.
Yes this can get outdated, but I would hope that not only the code example is checked when there is an error, but also the guide where the code is used. 😓
| </TsJsBlock> | ||
|
|
||
| In the code example above, the `queryDidDocument` function takes a web3Name parameter, which represents the web3name to be resolved. | ||
| It internally uses the `api.call.did.queryByWeb3Name` method to query the information of the provided web3name from the blockchain. |
Co-authored-by: Antonio <[email protected]>
ntn-x2
approved these changes
Jul 19, 2023
Dudleyneedham
pushed a commit
that referenced
this pull request
Jul 31, 2023
Co-authored-by: Antonio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/2780
🤖