K-14 list and set context (introduced configobj) #66

ms-shankar · 2019-11-04T15:44:32Z

Description

Closes issue 14 and issue 80

Checklist

An issue was first created before opening this pull request
The new code follows the kaos contribution guidelines
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests to ensure that prove my fix is effective or that my feature works

…4-list-contexts # Conflicts: # cli/kaos_cli/commands/build.py

…d backend init

aalhour

Potential NameError runtime bug, string formatting and use of prints.

cli/kaos_cli/commands/build.py

cli/kaos_cli/commands/workspace.py

cli/kaos_cli/facades/backend_facade.py

cli/kaos_cli/facades/workspace_facade.py

cli/kaos_cli/facades/backend_facade.py

aalhour · 2019-11-07T16:30:40Z

@ms-shankar - can you please commit and push your changes to the Pipfile and Pipfile.lock? It doesn't seem that the configobj library was added there.

aalhour · 2019-11-07T16:36:31Z

User Testing Session (No. 1)

I performed a fresh install of kaos.

`kaos` is broken

The kaos command is broken due to Pipenv not installing the configobj dependency:

➜ kaos
Traceback (most recent call last):
  File "/Users/ahmad/.local/share/virtualenvs/kaos-azHSaT7n/bin/kaos", line 11, in <module>
    load_entry_point('kaos', 'console_scripts', 'kaos')()
  File "/Users/ahmad/.local/share/virtualenvs/kaos-azHSaT7n/lib/python3.7/site-packages/pkg_resources/__init__.py", line 489, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/Users/ahmad/.local/share/virtualenvs/kaos-azHSaT7n/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2852, in load_entry_point
    return ep.load()
  File "/Users/ahmad/.local/share/virtualenvs/kaos-azHSaT7n/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2443, in load
    return self.resolve()
  File "/Users/ahmad/.local/share/virtualenvs/kaos-azHSaT7n/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2449, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/Users/ahmad/Workspace/kaos/cli/kaos_cli/__init__.py", line 2, in <module>
    from kaos_cli.factories.simple_factory import SimpleFactory
  File "/Users/ahmad/Workspace/kaos/cli/kaos_cli/factories/simple_factory.py", line 1, in <module>
    from kaos_cli.facades.backend_facade import BackendFacade
  File "/Users/ahmad/Workspace/kaos/cli/kaos_cli/facades/backend_facade.py", line 11, in <module>
    from kaos_cli.services.state_service import StateService
  File "/Users/ahmad/Workspace/kaos/cli/kaos_cli/services/state_service.py", line 4, in <module>
    from configobj import ConfigObj
ModuleNotFoundError: No module named 'configobj'

`kaos build list` raises an internal `TypeError` after fresh install

I fixed the above problem by installing configobj manually (it should be reflected in the Pipfile and Pipfile.lock though) and then tried performing a kaos build list but it seems broken:

➜ kaos build list
Warning - Unknown error: TypeError("object of type 'NoneType' has no len()")

`kaos build deploy -c DOCKER -vy` raises an internal `AttributeError` after successful deployment

➜ kaos build deploy -c DOCKER -vy
...
Apply complete! Resources: 21 added, 0 changed, 0 destroyed.

Warning - Unknown error: AttributeError("'BackendFacade' object has no attribute 'create_context'")

`kaos build list` still raises an internal `TypeError` even after successful deploy

➜ kaos build deploy -c DOCKER -vy
...
Apply complete! Resources: 21 added, 0 changed, 0 destroyed.
Warning - Unknown error: AttributeError("'BackendFacade' object has no attribute 'create_context'")

➜ kaos build list
Warning - Unknown error: TypeError("object of type 'NoneType' has no len()")

`kaos build set -c DOCKER` raises an internal `TypeError` after successful deploy

➜ kaos build set -c DOCKER
Warning - Unknown error: TypeError("'NoneType' object is not iterable")

`kaos destroy -c DOCKER -v[y]` raises an internal `KeyError`

➜ kaos destroy -c DOCKER -vy
Warning - Unknown error: KeyError('DOCKER')

Still breaks even without passing the y argument:

➜ kaos destroy -c DOCKER -v
Warning - Are you sure about destroying kaos backend in DOCKER? [y/N]: y
Warning - Unknown error: KeyError('DOCKER')

EDIT: Discovered and added more issues

cli/kaos_cli/commands/build.py

aalhour · 2019-11-08T14:34:09Z

@ms-shankar - kaos build list doesn't break anymore, but it's not reporting my existing docker build, also the kaos destroy command is still broken, heck out the following shell output:

➜ kaos build list
Warning - No active builds found. Please run kaos build deploy to deploy an environment

➜ kaos build deploy -c DOCKER -vy
Aborting - kaos backend is already built.

➜ kaos destroy -c DOCKER -vy
Warning - Unknown error: KeyError('DOCKER')

aalhour · 2019-11-08T14:48:45Z

Worked after force-build. You might want to include this in the CHANGELOG, a user out there might have to do a force-rebuild of their backend once they upgrade their kaos installation to your latest changes.

➜ kaos build deploy -c DOCKER -vyf
Apply complete! Resources: 1 added, 0 changed, 1 destroyed.

Info - Endpoint successfully set to http://localhost:80/api/
Info - Successfully built kaos environment

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

➜ kaos destroy -c DOCKER -vy
Destroy complete! Resources: 21 destroyed.
Info - Successfully destroyed kaos environment

➜ kaos build list
Warning - No active builds found. Please run kaos build deploy to deploy an environment

aalhour · 2019-11-08T15:02:33Z

Build backend on DOCKER:

➜ kaos build deploy -c DOCKER -vy
...

Apply complete! Resources: 21 added, 0 changed, 0 destroyed.

Info - Endpoint successfully set to http://localhost:80/api/
Info - Successfully built kaos environment

Get list of builds:

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

Deploy backend on AWS:

➜ kaos build deploy -c AWS -vy
...

Workspace "prod" already exists
Switched to workspace "prod".

...

module.registry.null_resource.build_push_tag[1]: Refreshing state... [id=676301818431185394]

Error: Failed to load config (; default context): invalid configuration: no configuration has been provided

  on ../../../../../../../Ahmad/Workspace/kaos/infrastructure/aws/envs/__working_prod/config.tf line 13, in provider "kubernetes":
  13: provider "kubernetes" {

...

module.registry.null_resource.build_push_tag[0]: Refreshing state... [id=3237394661645997731]
Error: Failed to load config (; default context): invalid configuration: no configuration has been provided
  on ../../../../../../../Ahmad/Workspace/kaos/infrastructure/aws/envs/__working_prod/config.tf line 13, in provider "kubernetes":
  13: provider "kubernetes" {

Warning - Unknown error: FileNotFoundError(2, 'No such file or directory')

aalhour · 2019-11-13T14:54:18Z

There is some weird behavior going on with destroy now. After calling kaos destroy, the kaos build list command started returning duplicate entries:

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

Destroy the backend

➜ kaos destroy -c DOCKER -vy
...
Destroy complete! Resources: 21 destroyed.
Info - Successfully destroyed kaos environment

After successful destroy, `kaos build list` still reports the existence of two backends

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+
|   1   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

Try to destroy the backend again, but `kaos destroy` says backend doesn't exist

➜ kaos destroy -c DOCKER -vy
Warning - kaos backend in DOCKER has not been deployed!

Backend doesn't exist but `kaos build list` says otherwise

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+
|   1   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

Filesystem Hierarchy

➜ tree .kaos
.kaos
├── config
└── state
    ├── AWS
    │   └── None
    └── GCP
        └── None

Tried to force rebuild `kaos`

➜ kaos build deploy -c DOCKER -vfy
...
Apply complete! Resources: 21 added, 0 changed, 0 destroyed.

Info - Endpoint successfully set to http://localhost:80/api/
Info - Successfully built kaos environment

`kaos buid list` now reports back 3 backends

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+
|   1   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+
|   2   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

Filesystem Hierarchy

➜ tree .kaos
.kaos
├── config
└── state
    ├── AWS
    │   └── None
    ├── DOCKER
    │   ├── config.json
    │   └── terraform.tfstate
    └── GCP
        └── None

6 directories, 3 files

ms-shankar · 2019-11-14T16:14:22Z

The earlier failure cases were due to incomplete deployments which were caused by stale infrastructure state configurations. The following test case scenarios were tested from my side (DOCKER + GCP stage):

(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build list    
+-------+-----------+----------+-------+
| index |  context  | provider |  env  |
+-------+-----------+----------+-------+
|   0   | GCP_stage |   GCP    | stage |
+-------+-----------+----------+-------+
|   1   |   DOCKER  |  DOCKER  | local |
+-------+-----------+----------+-------+
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build active  
Info - Active context is - DOCKER
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build set -i 0
Info - Successfully set to context - GCP_stage
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build active  
Info - Active context is - GCP_stage
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos destroy -c GCP -e stage -vy
Initializing modules...

Initializing the backend...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.
.
.
destroying <lines removed>
.
.
module.networking.google_compute_network.k8s-network: Still destroying... [id=kaos-2-stage-vnet, 10s elapsed]
module.networking.google_compute_network.k8s-network: Destruction complete after 17s

Destroy complete! Resources: 32 destroyed.
Info - Successfully destroyed kaos [stage] environment
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build active               
Info - Active context is - None
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build list  
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+
(kaos) KI-3162 :: KAOS/1/kaos ‹k-14-list-contexts*› » kaos build set -i 0
Info - Successfully set to context - DOCKER

aalhour · 2019-11-15T10:00:52Z

Tried to trick kaos into thinking that it has an AWS_dev deployment, a KeyError gets triggered:

➜ tree .kaos
.kaos
├── config
└── state
    ├── AWS
    │   └── dev
    │       └── None
    └── DOCKER
        ├── config.json
        └── terraform.tfstate

4 directories, 4 files


➜ kaos destroy -c AWS
Warning - Are you sure about destroying kaos [prod] backend in AWS? [y/N]: y
Warning - kaos [prod] backend in AWS has not been deployed!


➜ kaos destroy -c AWS -e dev
Warning - Are you sure about destroying kaos [dev] backend in AWS? [y/N]: y
Warning - Unknown error: KeyError('AWS_dev')

cli/kaos_cli/utils/validators.py

aalhour

kaos destroy command broke after pipenv update:

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+


➜ tree .kaos
.kaos
├── config
└── state
    ├── AWS
    │   └── dev
    │       └── None
    └── DOCKER
        ├── config.json
        └── terraform.tfstate

4 directories, 4 files


➜ kaos destroy -c DOCKER -vy
Warning - Unknown error: KeyError('None')

ms-shankar · 2019-11-18T14:33:50Z

The issue discovered above pertains to a failed deployment from the previous run. But while trying to simulate the reported issue another issue was discovered during destroy, which was:

(kaos) KI-3162 :: 1/2/kaos ‹k-14-list-contexts*› » kaos build destroy -c DOCKER -vy
Usage: kaos build [OPTIONS] COMMAND [ARGS]...
Try "kaos build --help" for help.

Error: No such command "destroy".
(kaos) KI-3162 :: 1/2/kaos ‹k-14-list-contexts*› » kaos destroy -c DOCKER -vy                                                                                                                                                     2 ↵
Initializing modules...

Initializing the backend...

Initializing provider plugins...

.
. <- More destroy lines ->

Destroy complete! Resources: 21 destroyed.
Warning - Unknown error: TypeError('sequence item 2: expected str instance, NoneType found')

kaos destroy logic has now been modified to handle empty env values as well. Tested OK

aalhour

kaos build set fails with an uncaught error when there is no backend built

➜ kaos build list
Warning - No active builds found. Please run kaos build deploy to deploy an environment

➜ kaos build set -i 0
Warning - Unknown error: TypeError('sequence item 2: expected str instance, NoneType found')

cli/kaos_cli/commands/build.py

…builds exist for list before deploy

aalhour

kaos train deploy is broken after refactor:

➜ kaos build deploy -c DOCKER -vy
...
Apply complete! Resources: 21 added, 0 changed, 0 destroyed.

Info - Endpoint successfully set to http://localhost:80/api/
Info - Successfully built kaos environment


➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+


➜ kaos workspace create -n mnist
Info - Successfully set mnist workspace


➜ kaos template get --name mnist
Info - Successfully loaded mnist template


➜ kaos train deploy -s templates/mnist/model-train \
                    -d templates/mnist/data
Warning - Missing endpoint! Please set with - kaos init

cli/kaos_cli/utils/decorators.py

aalhour

kaos workspace set is broken due to an uncaught exception

➜ kaos workspace list
+-----+-------+
| ind |  name |
+-----+-------+
|  0  | mnist |
+-----+-------+


➜ kaos workspace set -i 0
Warning - Unknown error: TypeError('list indices must be integers or slices, not str')

aalhour

kaos workspace kill doesn't work anymore

➜ curl -X POST localhost/serve-mnist-ba1759/invocations \
         --data-binary @templates/mnist/test_payload.jpg
{"result":[3]}


➜ kaos workspace kill
Warning - Are you sure about killing all mnist resources? [y/N]: y
in delete
Warning - Unknown error: TypeError("remove() got an unexpected keyword argument 'workspace'")

…igobj was introduced

ms-shankar · 2019-11-19T12:47:12Z

The issue with workspace set by index is not due to the introduction of configobj added in this PR. However, this issue has now been resolved.

The second issue with the workspace kill is due to the introduction of configobj and has now been adjusted to work correctly.

aalhour

I re-tested the Quickstart Guide, AWS Deployment as well as all previously discovered bugs; the issues are now solved. GCP deployments didn't go through but that has to do with some infrastructure issues that @ms-shankar has to look through.

LGTM.

) (#84) * Update documentation with latest kaos build changes

ms-shankar added 10 commits October 29, 2019 17:06

[WIP]: introduced json config file and changed service implementation

7a96139

Merge remote-tracking branch 'origin/master' into k-14-list-contexts

fcb1f95

[WIP]: confobj create list of contexts

4ec5f83

Merge branch 'k-14-list-contexts' of github.com:KI-labs/kaos into k-1…

9781712

…4-list-contexts # Conflicts: # cli/kaos_cli/commands/build.py

rebase with master

3beb313

[WIP] k-14 kaos build list completed

6b98346

[WIP] build list included in destroy

e766940

[WIP] set-contexts based on indices

69b6e50

[WIP] Modifying workspace facade, added context check decorator

67cc3fc

list context, set context based on both id and context

9b9aca3

ms-shankar changed the title ~~[WIP]: K-14 list contexts using configobj~~ K-14 list contexts using configobj Nov 7, 2019

ms-shankar requested review from aalhour and jfri3d November 7, 2019 13:44

ms-shankar marked this pull request as ready for review November 7, 2019 13:51

ms-shankar added 2 commits November 7, 2019 15:28

refactored other facades after the introduction of configobj, modifie…

b46baea

…d backend init

Merge remote-tracking branch 'origin/master' into k-14-list-contexts

393f14f

ms-shankar changed the title ~~K-14 list contexts using configobj~~ K-14 list and set context (introduced configobj) Nov 7, 2019

aalhour suggested changes Nov 7, 2019

View reviewed changes

aalhour reviewed Nov 7, 2019

View reviewed changes

cli/kaos_cli/commands/build.py Outdated Show resolved Hide resolved

aalhour reviewed Nov 7, 2019

View reviewed changes

cli/kaos_cli/commands/build.py Outdated Show resolved Hide resolved

ms-shankar added 2 commits November 7, 2019 18:35

Refactor changes 1/2

87bcd1b

Refactored 2/2, contributing.md added

4de192f

ms-shankar added 2 commits November 8, 2019 16:20

changed destroy logic to keep the KAOS_STATE_DIR intact

b58bd85

Added lock file

3602621

ms-shankar and others added 4 commits November 14, 2019 17:16

Reverted port collision validation which was removed for testing

120851b

fixed if_backend_successfully_built validation

7b60072

Merge branch 'master' into k-14-list-contexts

12bf2e0

bug fixed - if backend built already

e5ce32c

aalhour assigned ms-shankar Nov 15, 2019

aalhour added the feature label Nov 15, 2019

environment state added with methods + refactor

b1e0d93

aalhour suggested changes Nov 18, 2019

View reviewed changes

cli/kaos_cli/utils/validators.py Outdated Show resolved Hide resolved

cli/kaos_cli/utils/validators.py Outdated Show resolved Hide resolved

cli/kaos_cli/utils/validators.py Outdated Show resolved Hide resolved

cli/kaos_cli/utils/validators.py Outdated Show resolved Hide resolved

addressed review comments, added modified Pipfile.lock,

aeed2c8

aalhour suggested changes Nov 18, 2019

View reviewed changes

destroy logic handled better

528b228

aalhour suggested changes Nov 18, 2019

View reviewed changes

aalhour reviewed Nov 18, 2019

View reviewed changes

cli/kaos_cli/commands/build.py Outdated Show resolved Hide resolved

ms-shankar added 2 commits November 18, 2019 16:47

fixed incorrect Nonetype context in print message, also validated if …

385e71b

…builds exist for list before deploy

revert port validation fix

1050712

aalhour suggested changes Nov 18, 2019

View reviewed changes

aalhour reviewed Nov 18, 2019

View reviewed changes

cli/kaos_cli/utils/decorators.py Show resolved Hide resolved

fixed workspace namespace derivation after introducing configobj

23cd6b2

aalhour suggested changes Nov 19, 2019

View reviewed changes

fixed bug is workspace set (with index) and workspace kill after conf…

6cb9ae2

…igobj was introduced

aalhour approved these changes Nov 19, 2019

View reviewed changes

aalhour merged commit b6528ca into master Nov 19, 2019

aalhour deleted the k-14-list-contexts branch November 19, 2019 15:08

aalhour mentioned this pull request Nov 19, 2019

Update docs to accommodate kaos build command group refactoring (#14,#66) #84

Merged

8 tasks

ms-shankar pushed a commit that referenced this pull request Nov 27, 2019

Update docs to accommodate kaos build command group refactoring (#14,#66

654a948

) (#84) * Update documentation with latest kaos build changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

K-14 list and set context (introduced configobj) #66

K-14 list and set context (introduced configobj) #66

ms-shankar commented Nov 4, 2019 •

edited

Loading

aalhour left a comment

aalhour commented Nov 7, 2019

aalhour commented Nov 7, 2019 •

edited

Loading

aalhour commented Nov 8, 2019 •

edited

Loading

aalhour commented Nov 8, 2019

aalhour commented Nov 8, 2019

aalhour commented Nov 13, 2019 •

edited

Loading

ms-shankar commented Nov 14, 2019

aalhour commented Nov 15, 2019

aalhour left a comment

ms-shankar commented Nov 18, 2019 •

edited

Loading

aalhour left a comment

aalhour left a comment

aalhour left a comment

aalhour left a comment

ms-shankar commented Nov 19, 2019

aalhour left a comment

K-14 list and set context (introduced configobj) #66

K-14 list and set context (introduced configobj) #66

Conversation

ms-shankar commented Nov 4, 2019 • edited Loading

Description

Checklist

aalhour left a comment

Choose a reason for hiding this comment

aalhour commented Nov 7, 2019

aalhour commented Nov 7, 2019 • edited Loading

User Testing Session (No. 1)

kaos is broken

kaos build list raises an internal TypeError after fresh install

kaos build deploy -c DOCKER -vy raises an internal AttributeError after successful deployment

kaos build list still raises an internal TypeError even after successful deploy

kaos build set -c DOCKER raises an internal TypeError after successful deploy

kaos destroy -c DOCKER -v[y] raises an internal KeyError

aalhour commented Nov 8, 2019 • edited Loading

aalhour commented Nov 8, 2019

aalhour commented Nov 8, 2019

aalhour commented Nov 13, 2019 • edited Loading

Destroy the backend

After successful destroy, kaos build list still reports the existence of two backends

Try to destroy the backend again, but kaos destroy says backend doesn't exist

Backend doesn't exist but kaos build list says otherwise

Filesystem Hierarchy

Tried to force rebuild kaos

kaos buid list now reports back 3 backends

Filesystem Hierarchy

ms-shankar commented Nov 14, 2019

aalhour commented Nov 15, 2019

aalhour left a comment

Choose a reason for hiding this comment

ms-shankar commented Nov 18, 2019 • edited Loading

aalhour left a comment

Choose a reason for hiding this comment

aalhour left a comment

Choose a reason for hiding this comment

aalhour left a comment

Choose a reason for hiding this comment

aalhour left a comment

Choose a reason for hiding this comment

ms-shankar commented Nov 19, 2019

aalhour left a comment

Choose a reason for hiding this comment

ms-shankar commented Nov 4, 2019 •

edited

Loading

aalhour commented Nov 7, 2019 •

edited

Loading

`kaos` is broken

`kaos build list` raises an internal `TypeError` after fresh install

`kaos build deploy -c DOCKER -vy` raises an internal `AttributeError` after successful deployment

`kaos build list` still raises an internal `TypeError` even after successful deploy

`kaos build set -c DOCKER` raises an internal `TypeError` after successful deploy

`kaos destroy -c DOCKER -v[y]` raises an internal `KeyError`

aalhour commented Nov 8, 2019 •

edited

Loading

aalhour commented Nov 13, 2019 •

edited

Loading

After successful destroy, `kaos build list` still reports the existence of two backends

Try to destroy the backend again, but `kaos destroy` says backend doesn't exist

Backend doesn't exist but `kaos build list` says otherwise

Tried to force rebuild `kaos`

`kaos buid list` now reports back 3 backends

ms-shankar commented Nov 18, 2019 •

edited

Loading