Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sign up api 쿼리키 포맷 통일 #863 #871

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

publdaze
Copy link
Contributor

연관 이슈

작업 요약

  • sign up api 쿼리키 포맷 통일해주었습니다.

작업 상세 설명

(✅는 변경 후 정상동작 확인한 사항입니다!)

  • 포맷 통일
    • ✅ 로그인 중복 확인(useCheckLoginIdDuplicationQuery)
    • ✅ 이메일 중복 확인(useCheckEmailDuplicationQuery)
    • ✅ 학번 중복 확인(useCheckStudentIdDuplicationQuery)
  • 오타 수정
    • ✅ 회원가입 시 비밀번호 확인란 일치 여부 검증
    • ✅ 계정 변경 시 새 비밀번호 확인란 일치 여부 검증

To 리뷰어

  • 리팩토링하다가 개선 필요해보이는 부분 REVIEW 앵커로 주석 달아두었습니다. 언제 한 번 리팩토링 주제로 REVIEW, TODO 앵커 해결하기 넣어두어도 좋을 것 같아요!
  • params 변수 빼는 방식 이렇게 하면 될 지 확인 부탁드려요!

@publdaze publdaze added the Refactor 리팩토링 label Dec 28, 2023
@publdaze publdaze self-assigned this Dec 28, 2023
Copy link
Collaborator

@jasper200207 jasper200207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -257,7 +257,7 @@ const EditPasswordSection = () => {
rules={{
required: COMMON.error.required,
validate: {
confirmMatchPassward: (value) => {
confirmMatchPassword: (value) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍😆

Copy link
Member

@pipisebastian pipisebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@publdaze publdaze merged commit 7e941a5 into develop Jan 18, 2024
1 check passed
@publdaze publdaze deleted the feature/signUpApi_쿼리키_포맷_통일_#863 branch January 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 리팩토링
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

signUpApi 쿼리키 포맷 통일
3 participants