Feature/library api 쿼리키 포맷 통일 #866 #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipisebastian
commented
Dec 28, 2023
| page?: number; | ||
| size?: number; | ||
| } | ||
|
|
There was a problem hiding this comment.
이거 사용하려고 앞부분으로 위치바꿨습니다!
| useCancleReturnBookMutation, | ||
| useCancleBorrowBookMutation, | ||
| useCancelReturnBookMutation, | ||
| useCancelBorrowBookMutation, |
There was a problem hiding this comment.
함수 네이밍 변경한거랑, cancle로 오타났었어서.. 수정했습니다!
jasper200207
approved these changes
Jan 16, 2024
src/api/libraryApi.ts
Outdated
| borrowedBookList: ['library', 'borrowedBookList'] as const, | ||
| base: ['books'], | ||
| bookList: (params: BookListSearch) => [...libraryKeys.base, params] as const, | ||
| borrowedBookList: () => [...libraryKeys.base, 'bookBorrows'] as const, |
publdaze
reviewed
Jan 16, 2024
src/api/libraryApi.ts
Outdated
| borrowedBookList: ['library', 'borrowedBookList'] as const, | ||
| base: ['books'], | ||
| bookList: (params: BookListSearch) => [...libraryKeys.base, params] as const, | ||
| borrowedBookList: () => [...libraryKeys.base, 'bookBorrows'] as const, |
There was a problem hiding this comment.
파라미터 안 넘겨주는 경우는 함수형으로 안하고 바로 배열로 해도 될 것 같아요!
에러 이슈 확인했습니다!
publdaze
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
작업 요약
useGetBookBorrowsQuery->useGetBorrowedBookListQuery로 네이밍 변경리뷰 요구사항