Feature/#399 개발 중단된 CTF, 선거, 활동조사 도메인 처리 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkisme
changed the title
shkisme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
close: #395, #399
📝 Description
CTF 기능은 앞으로 홈페이지 내부 기능으로 들어갈 가능성이 없기 때문에, 일괄 삭제하였습니다. (열심히 짠 코드들이라 아까운 마음에 ctf 브랜치 따놓았어요...🥲)
선거 파트의 경우 기능 추가될 여지가 있어보여서 일단 놔두는게 좋아보입니다.
또, 회원 랭킹 조회 API에 memberId를 추가했습니다. 랭킹 페이지에서 회원 페이지로 리다이렉션하기 위해 필요합니다. 매우 간단한 작업이라 이번 PR에서 같이 진행했습니다.
⭐️ Review Request
없습니다!