-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kdt5 moon dae hyun #69
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
부족한점 코멘트 드렸습니다.
const theFooter = new TheFooter().el | ||
const routerView = document.createElement('router-view') | ||
|
||
this.el.append( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
방식 통일 부탁드립니다.
export default class Headline extends Component { | ||
render() { | ||
this.el.classList.add('headline') | ||
this.el.innerHTML = /* html */ ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위파일이랑 어떤걸로 할지 방식 통일 부탁드립니다.
movie | ||
}).el) | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fragment노드 쓰시는것 추천드립니다.
acc[key] = value | ||
return acc | ||
}, {}) | ||
history.replaceState(query, '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushState, replaceState 차이도 알아보세요
const headline = new Headline().el | ||
const search = new Search().el | ||
const movieList = new MovieList().el | ||
const movieListMore = new MovieListMore().el |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
el을 처음부터 내보내주면 되지않나요?
|
||
try{ | ||
// const res = await fetch(`https://omdbapi.com?apikey=7035c60c&s=${store.state.searchText}&page=${page}`) | ||
const res = await fetch('/api/movie', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetch는 분리해주세요
store.state.loading = false | ||
} | ||
} | ||
export const getMovieDetails = async id => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api함수끼리는 분리 부탁드립니다.
JS과제제출