fix: Fix json loading in gui #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loading was working to be able to use the JsonDocument API, but it didn't work in the GUI to display the file. This is fixed, and we update the underlying json model after each save.
LeonMatthesKDAB
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Overall this fixes the problem that JSON documents aren't loading at all.
However, I want to point out that this is still not bug-free!
If I see it correctly, editing the document in Knuts text view won't update the m_jsonData.
These changes therefore won't be reflected in the ::value/::hasValue calls.
::setValue will also override any changes to the document that weren't saved.
Overall, the JsonDocument still needs some more work, but this is moving in the right direction.
|
I agree with you, there is still an issue syncing both representation of the json file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loading was working to be able to use the JsonDocument API, but it
didn't work in the GUI to display the file.
This is fixed, and we update the underlying json model after each save.