Tracepoint #508

lievenhey · 2023-09-21T11:51:56Z

Show tracepoints in TimeLineWidget

lievenhey · 2023-09-21T16:08:51Z

src/models/eventmodel.cpp

src/parsers/perf/perfparser.cpp

src/models/timelinedelegate.cpp

src/models/eventmodel.h

src/models/eventmodel.cpp

src/models/eventmodel.h

src/models/eventmodel.cpp

tests/modeltests/tst_models.cpp

milianw

there are still no unit tests for any of the new functionality - we need both! i.e. tests for the new behavior of showing tracepoint events in the model, and tests for the favorite.

we also cannot yet undo a favorite action, i.e. remove a favorite

src/models/eventmodel.cpp

src/models/timelinedelegate.cpp

src/models/eventmodel.cpp

src/models/timelinedelegate.cpp

src/models/eventmodelproxy.cpp

src/models/eventmodelproxy.h

milianw

hey @lievenhey - I cleaned up the remaining nits and played around with this. It definitely goes into the right direction.

but there is more work remaining to make this actually useful:

the biggest issue is that all tracepoints for all threads and processes are lumped together into a single row - that is pretty useless.

the way I see it, our "Event Sources" should become a combo box that allows multi-selection. Then, each of these event sources will get one row below the CPU or Thread group.

The proxy should then flatten this, if just a single cost is selected - i.e. such that we keep the view as-is for data files that don't contain any extra tracepoint data.

Right now with your proposed patch here, one can have "Event Source: " and then we'd see the per-thread tracepoints and then one more row with all tracepoints clumped together 🤷 that's not useful

additionally, the tooltips shown in the event delegate are wrong when hovering a tracepoint event, because it only looks at the events of the selected source type, meaning tracepoints are never considered.

once those things are fixed, I am OK with merging this work as a stepping stone. the following steps will then be:

time measurement between enter/exit similar to off-CPU time
somehow making sure that the favorite rows are always shown, independent of the vertical current scroll position - potentially through a second view?

lievenhey · 2023-10-05T11:09:24Z

somehow making sure that the favorite rows are always shown, independent of the vertical current scroll position - potentially through a second view?

using a second view is most likely the easiest option since QWidgets don't have stuff like qmls header or footer

milianw · 2023-10-07T09:15:33Z

somehow making sure that the favorite rows are always shown, independent of the vertical current scroll position - potentially through a second view?

using a second view is most likely the easiest option since QWidgets don't have stuff like qmls header or footer

Agreed, we just need to sync the views and show just a single header somehow. But this should/ could be done in a follow-up patch and doesn't necessarily block integration of the work here as long as the other important issues are resolved.

GitMensch · 2023-11-14T14:12:05Z

Is this still in a draft state? It seems that new testcases are now available (but failing) are there still missing ones?

lievenhey · 2023-11-28T14:00:34Z

@milianw I finally found some time to work in this. Can you check if it to your satisfaction?

milianw · 2023-12-10T11:46:38Z

are you sure you pushed the correct work? I don't think you attended the issue I raised above, namely:

the biggest issue is that all tracepoints for all threads and processes are lumped together into a single row - that is pretty useless.

I just checked out your branch, rebased it on master and ran it on data I obtained with

perf record -z --call-graph dwarf -e cycles -e raw_syscalls:sys_enter -e raw_syscalls:sys_exit ./tests/test-clients/cpp-parallel/cpp-parallel

The result is still a single list of tracepoints across all threads, which is not useful. What's worse, some threads are suddenly showing up multiple times in the timelines above?

lievenhey · 2024-01-15T16:29:30Z

Ok, fixed that. Now all events are shown in one line (before there was one line per even type).
That is still somewhat wip since now it is really hard to differentiate different event types since only the tooltip reveals the type. I propose the following:

different colors for different event types
when hovering highlight not only all stacks but also all symbols with the same type

Since we use QSortFilterProxyModel we get this for free. This patch adds support for regex search by not escaping the search term if it is prefix with %. For the flamegraph there is a custom implementation, which changes the current QString::contains to a QRegularExpression::match call. Closes: #508

The tracepoints are getting a better visual representation on the timelinewidget so this is no longer necessary.

Move the tracepoints from TimeAxisHeaderView to TimeLineWidget so that we can use the header for cpu usage. This also improves usability since the tracepoints are no longer bundles in one line. They now each have their own line.

Enum automatically counts up so there is no need to manually set these values.

this allows the user to group important timelines together so that he can compare them better

The favourites and tracepoint patches include some rows in the model that may be empty. To keep the code simple an readable all rows will be shown. Then a proxy model is put ontop to remove empty rows.

This way we can more easily find them and changing the sort order doesn't move them to the bottom.

Showing only one cost is fine if we only show a hardware event, but since we now support tracepoints and some come in an enter/exit pair it requires us to rework the timeline delegate. This patch makes the event source combobox multi select and allows to select multiple event sources.

lievenhey force-pushed the tracepoint branch 2 times, most recently from d54b806 to 5e1dd33 Compare September 21, 2023 12:43

milianw requested changes Sep 22, 2023

View reviewed changes

lievenhey force-pushed the tracepoint branch 3 times, most recently from e481527 to 2b03816 Compare September 29, 2023 17:11

milianw requested changes Oct 1, 2023

View reviewed changes

lievenhey force-pushed the tracepoint branch 2 times, most recently from 13acd7e to 1daf271 Compare October 2, 2023 09:17

milianw requested changes Oct 2, 2023

View reviewed changes

src/models/eventmodel.cpp Outdated Show resolved Hide resolved

src/models/timelinedelegate.cpp Outdated Show resolved Hide resolved

lievenhey force-pushed the tracepoint branch 4 times, most recently from 505cf1e to 150e3e3 Compare October 4, 2023 11:04

milianw force-pushed the tracepoint branch from 150e3e3 to 52dc89b Compare October 4, 2023 20:12

milianw reviewed Oct 4, 2023

View reviewed changes

milianw requested changes Oct 4, 2023

View reviewed changes

lievenhey force-pushed the tracepoint branch 3 times, most recently from 0506b95 to 52dc89b Compare October 5, 2023 10:51

lievenhey force-pushed the tracepoint branch from 52dc89b to 28e0037 Compare October 31, 2023 11:02

lievenhey force-pushed the tracepoint branch from f0ef9d6 to a042f06 Compare November 28, 2023 13:58

lievenhey requested a review from milianw November 28, 2023 14:12

lievenhey force-pushed the tracepoint branch 2 times, most recently from 4fafd04 to 8b63f7d Compare November 28, 2023 14:15

lievenhey force-pushed the tracepoint branch 2 times, most recently from 9fa7c07 to a05cc6d Compare November 28, 2023 14:23

lievenhey force-pushed the tracepoint branch 2 times, most recently from 48c9f49 to e80f5f6 Compare January 15, 2024 15:02

lievenhey force-pushed the tracepoint branch from e80f5f6 to e7ebfac Compare February 6, 2024 10:42

lievenhey added the enhancement label Feb 6, 2024

lievenhey force-pushed the tracepoint branch from e7ebfac to e236c9d Compare May 29, 2024 09:01

lievenhey force-pushed the tracepoint branch 2 times, most recently from 3c12c0a to c2720e3 Compare November 18, 2024 13:09

lievenhey added 4 commits November 18, 2024 14:27

feat: remove tracepoints from timeaxisheaderview

ce7e7d1

The tracepoints are getting a better visual representation on the timelinewidget so this is no longer necessary.

feat: show tracepoints in the timelinewidget

c5f2414

Move the tracepoints from TimeAxisHeaderView to TimeLineWidget so that we can use the header for cpu usage. This also improves usability since the tracepoints are no longer bundles in one line. They now each have their own line.

feat: simplify tag enum

04ddce9

Enum automatically counts up so there is no need to manually set these values.

feat: add Favourites to TimeLineWidget

200d6de

this allows the user to group important timelines together so that he can compare them better

lievenhey force-pushed the tracepoint branch from c2720e3 to adf4a37 Compare November 18, 2024 13:27

lievenhey and others added 3 commits November 18, 2024 17:09

feat: add QSFP to hide empty rows in eventmodel

fe4ff35

The favourites and tracepoint patches include some rows in the model that may be empty. To keep the code simple an readable all rows will be shown. Then a proxy model is put ontop to remove empty rows.

feat: Always put the favorite contents on the top of the view

b2ebd1f

This way we can more easily find them and changing the sort order doesn't move them to the bottom.

lievenhey force-pushed the tracepoint branch from adf4a37 to 89f14ee Compare November 18, 2024 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracepoint #508

Tracepoint #508

lievenhey commented Sep 21, 2023

lievenhey commented Sep 21, 2023

milianw left a comment

milianw left a comment

lievenhey commented Oct 5, 2023

milianw commented Oct 7, 2023

GitMensch commented Nov 14, 2023

lievenhey commented Nov 28, 2023

milianw commented Dec 10, 2023

lievenhey commented Jan 15, 2024

Tracepoint #508

Are you sure you want to change the base?

Tracepoint #508

Conversation

lievenhey commented Sep 21, 2023

lievenhey commented Sep 21, 2023

milianw left a comment

Choose a reason for hiding this comment

milianw left a comment

Choose a reason for hiding this comment

lievenhey commented Oct 5, 2023

milianw commented Oct 7, 2023

GitMensch commented Nov 14, 2023

lievenhey commented Nov 28, 2023

milianw commented Dec 10, 2023

lievenhey commented Jan 15, 2024