cxx-qt-build: return an Interface from CxxQtBuilder #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-experiments
branch
from
8f18f8a to
6a6c7c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12772
=========================================
Hits 12772 12772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-experiments
branch
3 times, most recently
from
9f8bd4e to
4bb39aa
Compare
|
Overall looking good, does now need a rebase now the other branch has landed, unsure if it'll conflict in any way. |
This still needs more refactoring later but is a first step.
This allows export() to have no args meaning we can return an Interface from the compile command next.
We however have two changes compared to CXX: 1. We allow you to change the root of the automatic include directory. 2. We allow you to include additional directories. Both of these changes are there to accomodate crates like cxx-qt-lib, that want to use e.g. `<cxx-qt-lib/qstring.h>` instead of `<cxx-qt-lib/include/qstring.h>`. Also cxx-qt-lib generates a definitions header which we need to include.
This is no longer needed. Also clean up some documentation on the API.
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-experiments
branch
from
4bb39aa to
f0c7317
Compare
The function will now panic if it is called multiple times.
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-experiments
branch
from
8245fd7 to
adc3164
Compare
ahayzen-kdab
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on #1285.
The main difference is in how include paths are handled for the CXX-style automatic include of the header directory.
In this PR, the root of the automatic inclue can be configured.
This leads to less changes for downstream crates.
It also allows us to move to an include system of "cxx-qt-lib/core/qstring.h" while keeping backwards-compatibility with forwarding-headers