qt-build-utils: build system changes to have a QtInstallation #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just to test what we can do still with the old API
This now also prints out the paths that were attempted.
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
21e8b6e to
5dea07e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12772
=========================================
Hits 12772 12772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
5dea07e to
ab9dd5e
Compare
Also only compile in the `new` function if the `qmake` feature is provided. Previously this function would not run anyhow. If we add a `cmake` feature, we can conditionally enable the function if either `cmake` or `qmake` is enabled.
LeonMatthesKDAB
force-pushed
the
1125-build-system-changes-qtinstallation
branch
from
ab9dd5e to
6c2ce2f
Compare
|
Changes look good though, feel free to merge if your happy with it too |
|
I can't seem to approve this it causes github to error 500 :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake of #1230, as I accidentally managed to close that PR.
This includes the changes that I requested on #1230.
This is part of one of the steps towards #1125 and rewriting qt-build-utils.