ci: set the CARGO_BUILD_TARGET to reuse same cache #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 12772 12772
=========================================
Hits 12772 12772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahayzen-kdab
force-pushed
the
ci-share-cmake-cargo-build
branch
3 times, most recently
from
c1cf039 to
2f73836
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
force-pushed
the
ci-share-cmake-cargo-build
branch
from
2f73836 to
ca785db
Compare
Corrosion sets the --target flag to rustc which means that crates are built in the target sub folder. Ensure that other places that call cargo directly reuse this same folder by setting CARGO_BUILD_TARGET.
ahayzen-kdab
force-pushed
the
ci-share-cmake-cargo-build
branch
from
ca785db to
7417574
Compare
This is likely not required anymore.
ahayzen-kdab
commented
May 30, 2025
| @@ -422,6 +429,8 @@ jobs: | |||
| SCCACHE_CACHE_SIZE: 600M | |||
| SCCACHE_LOG: debug | |||
| SCCACHE_ERROR_LOG: ${{ matrix.sccache_log_path }} | |||
| # Ensure that we share the same target sub folder | |||
There was a problem hiding this comment.
Wonder how much sharing there can be between the builds, or if they are ultimately different anyway and need separate folders/caches. (cmake vs cargo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1192