Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDDL fixes and improvements #196

Merged
merged 7 commits into from
Jun 20, 2019
Merged

Conversation

gerardcanal
Copy link
Contributor

It includes different fixes:

  • CMake flags for rddl parser
  • Added some services to get type of fluents (including enumerable types)
  • Removed ippc2018 flag for rddl parser in RDDLTaskParser line 35 which may cause some endless loop when parsing some domains
  • Fixed RDDLSIMPlannerInterface
  • Fixed RDDLProblemGenerator with enum types
  • Fixed some typos

Copy link
Contributor

@m312z m312z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what kind of relation enumerable types might have to constants, and what would be required to have an interface that adapts the RDDL KB to PDDL and vice versa.

@m312z
Copy link
Contributor

m312z commented Jun 20, 2019

As another comment, a service that fetches the type of an object instance could also be added to the PDDL KB, as noted in issue #203. Is it possible that they share message types? If so, then that future PR could change the file and variable names.

@m312z m312z merged commit 6280de3 into KCL-Planning:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants