Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stone torch dynamic light data. #350

Open
wants to merge 1 commit into
base: 1.21
Choose a base branch
from

Conversation

LambdAurora
Copy link

For a long time LambDynamicLights has provided a JSON file for dynamic lighting of Adorn's stone torch with the goal to be similar to its own default data for Vanilla torches.

Though I think it might make more sense if that file is directly in Adorn, and given it's just a JSON file I figured it shouldn't be too much of a constraint.

This file tells LambDynamicLights that, for every Adorn stone torch items, it should:

  • use the same luminance value as the stone torch block
  • and is sensitive in water, so it can turn off underwater since torches cannot be placed underwater.

I've put it into the common assets since some LambDynamicLights' NeoForge forks provide the same data-driven feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant