[draft] email account sign up & settings QA demo branch #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1188537.
This makes updates to content for login/signup flow for more consistency with header/sub-header text. Also remove an old step for "verify reminder" that wasn't being used. Also cuts a line about sending error report from verify page. [sc-14236] Also centers the resend verify email within the sign up modal [sc-14270] I also clean up the login styles - nothing other than the following was added, everything else just rearranged to make it a little more clear.
* sc-14206 align address tool bar buttons * sc-13965 sc-14211 send new link font and alignment * sc-14220 left align get repairs link * remove unnecessary styling * [sc-14207] [sc-14051] update nav bar to reflect more current design system mocks, fix wrapping nav bar buttons, hand icon on hover * demosite tag alignment in mobile
Previous the signup flow from Nav would end after user type selection and redirect users to the account settings page. This was confusing during initial user testing since it never said anything about email verification until later it was show on building pages, also there is no need to do anything on account settings after sign up. This PR removes that redirect and shows the same "verify email" prompt as we show at the end of the on-page/in-modal sign up flow. So the final step looks like this.
content update for user type options
This adds a standardized "standalone" page design for login/signup, forgot-password, reset-password, verify email (plus a modified version for unsubscribe/manage subscriptions). [sc-14218] This new page also gets a new minimal footer. [sc-13964] Mobile styles are also fixed for all these pages with the new layout. [sc-14066] All automatic/countdown redirects are removed from login/signup via nav, reset-password and verify. [sc-14144] The login flow from nav now has an extra final step. If not verified you get the same prompt to do so as at the end of sign up, and it sends a new email. And if you are already verified then you get a a new "success" step with a link to the homepage. Focus now automatically shifts to the password input after submitting email in the login/signup flows. [sc-14271] Also, I realized there was a bad copy/paste error on the reset-password page - it was sending a verify email instead of a reset one! So I fixed that and also realized there was a problem with the request because cookies weren't getting sent and those are needed for accessing session on the auth server. I also changed the JF logo svg (also used in nav) to a component so that we can make use of the "currentColor" to style with css instead of adding a second black version.
* fix broken pw reset request with token * add standalone page, start transitioning over * add login success step, mobile standalone styles, footer * fix footer alignment, and page scrolling on mobile * fix desktop styles, add link to JF logo * remove unused prop for redirects * greyed out site for modal color darkened, manage subscriptions page style update * other account settings style updates * remove unused import * Update client/src/styles/AccountSettingsPage.scss Co-authored-by: Maxwell Austensen <[email protected]> * Update client/src/styles/AccountSettingsPage.scss Co-authored-by: Maxwell Austensen <[email protected]> * Update client/src/styles/UserSetting.scss Co-authored-by: Maxwell Austensen <[email protected]> * Update client/src/styles/AccountSettingsPage.scss Co-authored-by: Maxwell Austensen <[email protected]> --------- Co-authored-by: Maxwell Austensen <[email protected]> Co-authored-by: Maxwell Austensen <[email protected]>
There's some weird issue with lingui (the very old version we're on) where the lingui extract doesn't work on if it's imported before Trans (lingui/js-lingui#372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.