Skip to content

Added instructions for deployment with Docker #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

nicole-brewer
Copy link
Contributor

I'd still like to add a section about "Deploying with The Littlest JupyterHub and the Voila Dashboard Plugin"

@mwcraig
Copy link
Collaborator

mwcraig commented Jul 8, 2024

Looks good so far!

"\n",
"1. [Install Docker](https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository). Note that you may need admin access to run Docker commands.\n",
"2. Start a command line (terminal) session.\n",
"3. Make sure Docker by executing `docker info`.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"3. Make sure Docker by executing `docker info`.\n",
"3. Make sure Docker is installed by executing `docker info`.\n",

Copy link
Collaborator

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I haven't tried building the docker image yet

Copy link
Collaborator

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough!

@JuanCab JuanCab merged commit a44e103 into Jupyter4Science:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants