fix goto_last_window #373
Merged
fix goto_last_window #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR and the kind words! That's... "funny", you'd have thought I'd have noticed that but I guess I personally use the jumplist more often than this mapping. It'd be good to add a test for this I think before merging. You might be able to cargo cult the tests you see e.g. in spec/infoview/open_close_spec.lua in order to create some simple new spec file without knowing much Lua (or much about the project yet). But I'm also quite happy to help or to do so myself if you run into trouble. Does that sound like something you could have a look at? Regardless thanks for sending the PR! |
|
@Julian I added some tests for jumps between Lean file and infoview, lmk if they make sense. |
Julian
reviewed
Jan 9, 2025
Julian
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jumping back to the associated lean file from the current infoview does not work in the current version.
The bug is that the
selfingoto_last_windowrefers to the metatableInfoinstead of thenew_infotable (wherelast_windowis set).I'm not familiar with this project nor Lua, so hopefully this fix makes sense.
Thanks for the awesome nvim plugin, btw!