Fix idempotency issue #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This looks pretty reasonable. I'm not really happy with the way we have config now in some other ways which is #39 but this definitely looks like an improvement! Let me know when/if it's ready to review. |
It turns out that most of these come from the `_DEFAULTS` pattern. This
is because of the following:
original state:
```lua
tbl = { _DEFAULTS = ... }
```
after configuration with empty table, `tbl = vim.tbl_extend(tbl._DEFAULTS, {})`
which practically replaces `tbl` by `tbl._DEFAULTS`:
```lua
tbl = { ... }
```
after this, the next call to `vim.tbl_extend(tbl._DEFAULTS, {})` fails, as
`tbl._DEFAULTS` is nil.
The solution to this is to just call `vim.tbl_extend(tbl, ...)` and store the
defaults in `tbl` itself. The `._DEFAULTS` field can be preserved by copying to
it after initialization.
Also `command` has been replaced with `command!` in vimscript and
`autocmd`s have been wrapped in an `augroup` which resets its state each
call. This is also common practice that avoids duplicate autocommands.
Fixes Julian#145
4e554c4c
force-pushed
the
idempotency
branch
from
9ce2ffc to
b02b15f
Compare
test plan: ``` $ TEST_FILE=lua/tests/setup_spec.lua ./lua/tests/scripts/run_tests.sh ======================================== Testing: lua/tests/setup_spec.lua Success || lean.setup Does not crash when loaded twice Success: 1 Failed : 0 Errors : 0 ======================================== ```
4e554c4c
force-pushed
the
idempotency
branch
from
b8dfe0e to
6bfcc51
Compare
|
should be good to review now, thanks :) |
|
Looks great! Really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that most of these come from the
_DEFAULTSpattern. Thisis because of the following:
original state:
after configuration with empty table,
tbl = vim.tbl_extend(tbl._DEFAULTS, {})which practically replaces
tblbytbl._DEFAULTS:after this, the next call to
vim.tbl_extend(tbl._DEFAULTS, {})fails, astbl._DEFAULTSis nil.The solution to this is to just call
vim.tbl_extend(tbl, ...)and store thedefaults in
tblitself. The._DEFAULTSfield can be preserved by copying toit after initialization.
Also
commandhas been replaced withcommand!in vimscript andautocmds have been wrapped in anaugroupwhich resets its state eachcall. This is also common practice that avoids duplicate autocommands.
Fixes #145