Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAI-28133] Output an error when worker_init_expr is set but test workers are zero #162

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

nantiamak
Copy link
Collaborator

Currently, if test workers are zero, worker_init_expr won't run even if it's defined.
This PR returns an error in this case.

A @testset is added in test/integrationtests.jl.

@nantiamak nantiamak marked this pull request as ready for review July 12, 2024 15:51
@nantiamak nantiamak requested review from Drvi and NHDaly July 12, 2024 15:51
@NHDaly NHDaly changed the title Output an error when worker_init_expr is set but test workers are zero [RAI-28133] Output an error when worker_init_expr is set but test workers are zero Jul 12, 2024
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Nantia! 👍

@NHDaly NHDaly merged commit f25832e into main Jul 12, 2024
7 checks passed
@NHDaly NHDaly deleted the nm-error-worker-init-expr-set-zero-workers branch July 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants