Remove date time internals #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into Remove_DateTime_Internals
…into Remove_DateTime_Internals
|
Very nice @jmurphy6895 ! To fix tests, we need to add ForwardDiff UUID in |
|
Hi @jmurphy6895 ! I was testing here and I am seeing a lot of type instabilities in the interpolations functions. See the Cthulhu.jl output of the current version: 
against the one in this PR: 
This behavior is caused probably due to something in the new definition of the types. |
|
I could fix it! It was a type definition in the structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Internal Representation of Current Time with JD instead of DateTime to allow for AutoDiff Capabilities