Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete overhaul of implementation taken from Rematch2.jl #78

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Conversation

gafter
Copy link
Member

@gafter gafter commented Aug 2, 2023

  • Code generation via an optimized decision automaton
  • Require Julia 1.5
  • No longer supports multidimensional arrays

* Code generation via an optimized decision automaton
* Require Julia 1.5
* No longer supports multidimensional arrays
@gafter gafter requested a review from quinnj August 2, 2023 21:04
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +20.62% 🎉

Comparison is base (6f0c04e) 79.37% compared to head (7bac0a1) 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             main       #78       +/-   ##
============================================
+ Coverage   79.37%   100.00%   +20.62%     
============================================
  Files           3        12        +9     
  Lines         286      1036      +750     
============================================
+ Hits          227      1036      +809     
+ Misses         59         0       -59     
Files Changed Coverage Δ
src/Match.jl 100.00% <100.00%> (ø)
src/automaton.jl 100.00% <100.00%> (ø)
src/binding.jl 100.00% <100.00%> (ø)
src/bound_pattern.jl 100.00% <100.00%> (ø)
src/immutable_vector.jl 100.00% <100.00%> (ø)
src/lowering.jl 100.00% <100.00%> (ø)
src/match_cases_opt.jl 100.00% <100.00%> (ø)
src/match_cases_simple.jl 100.00% <100.00%> (ø)
src/match_return.jl 100.00% <100.00%> (ø)
src/matchmacro.jl 100.00% <100.00%> (+19.90%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gafter gafter requested a review from mcmcgrath13 August 2, 2023 21:08
@gafter
Copy link
Member Author

gafter commented Aug 2, 2023

@mcmcgrath13 Please review. This is almost exactly just moving the code from Rematch2.jl.

Project.toml Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small comments and we should make sure the docs work, but otherwise this looks good to me.

Caveat: I did not review the code and tests as it looks like a copy/paste from the other repo where that code has already been reviewed - let me know if there's anything I should have really looked at

@gafter gafter merged commit 37f4c35 into main Aug 3, 2023
@gafter gafter deleted the Rematch2 branch August 3, 2023 17:09
@quinnj
Copy link
Member

quinnj commented Aug 3, 2023

Great stuff. The typical pattern for Julia packages is to actually hold off on doing the actual git tag until the General registry update is done (and then let the TagBot GHA do the git tag for us). So let me know if you want any help with publishing the upgrade?

julia = "0.7, 1"
MacroTools = "0.4, 0.5"
OrderedCollections = "1"
julia = "1.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR description says "requires julia 1.5", but your Project.toml (and CI) support 1.4.

Update whichever is wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants