-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete overhaul of implementation taken from Rematch2.jl #78
Conversation
gafter
commented
Aug 2, 2023
- Code generation via an optimized decision automaton
- Require Julia 1.5
- No longer supports multidimensional arrays
* Code generation via an optimized decision automaton * Require Julia 1.5 * No longer supports multidimensional arrays
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
============================================
+ Coverage 79.37% 100.00% +20.62%
============================================
Files 3 12 +9
Lines 286 1036 +750
============================================
+ Hits 227 1036 +809
+ Misses 59 0 -59
☔ View full report in Codecov by Sentry. |
@mcmcgrath13 Please review. This is almost exactly just moving the code from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple small comments and we should make sure the docs work, but otherwise this looks good to me.
Caveat: I did not review the code and tests as it looks like a copy/paste from the other repo where that code has already been reviewed - let me know if there's anything I should have really looked at
Great stuff. The typical pattern for Julia packages is to actually hold off on doing the actual git tag until the General registry update is done (and then let the TagBot GHA do the git tag for us). So let me know if you want any help with publishing the upgrade? |
julia = "0.7, 1" | ||
MacroTools = "0.4, 0.5" | ||
OrderedCollections = "1" | ||
julia = "1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR description says "requires julia 1.5", but your Project.toml (and CI) support 1.4.
Update whichever is wrong?