refactored multi agent proposal#926
Open
Mytolo wants to merge 2 commits intoJuliaReinforcementLearning:mainfrom
Open
refactored multi agent proposal#926Mytolo wants to merge 2 commits intoJuliaReinforcementLearning:mainfrom
Mytolo wants to merge 2 commits intoJuliaReinforcementLearning:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
- Coverage 13.64% 0.00% -13.65%
==========================================
Files 217 208 -9
Lines 7571 7415 -156
==========================================
- Hits 1033 0 -1033
- Misses 6538 7415 +877
🚀 New features to boost your workflow:
|
Contributor
Author
Member
|
Doesn't the new loop work for you ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning a generator for RLBase.plan! use NamedTuples s.t. the environment is able to gather the actions for the players correctly. It might be that the iteration of the environment is not in order (for example, this might occur when it is wrapped from another language into julia).
Moreover, this PR includes proper push operations for the Basic
Agentpolicy for simultaneous dynamicStyle trait envs. They were missing. Hence, the trajectory was not updated acordingly.