Skip to content

Commit

Permalink
Add regression test that all imports keep being explicit.
Browse files Browse the repository at this point in the history
  • Loading branch information
@GunnarFarneback
GunnarFarneback committed Jun 11, 2024
1 parent 118c0f0 commit b5ff4d5
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions test/runtests.jl
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,22 @@
import RegistryTools
using Test: @testset, @test
import Pkg

@testset "RegistryTools" begin

include("regedit.jl")
include("compress.jl")

# ExplicitImports does not support as old Julia versions as RegistryTools does.
# Change this to a regular test dependency when it becomes possible, i.e.
# when pre-1.7 support is dropped.
if VERSION >= v"1.7"
Pkg.add(name = "ExplicitImports", uuid = "7d51a73a-1435-4ff3-83d9-f097790105c7", preserve=Pkg.PRESERVE_ALL)
using ExplicitImports: check_no_implicit_imports, check_no_stale_explicit_imports
@testset "ExplicitImports" begin
@test isnothing(check_no_implicit_imports(RegistryTools))
@test isnothing(check_no_stale_explicit_imports(RegistryTools))
end
end

end

2 comments on commit b5ff4d5

@GunnarFarneback
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/108756

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.3.0 -m "<description of version>" b5ff4d541b0aad2261ac21416113cee9718e28b3
git push origin v2.3.0

Please sign in to comment.