Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AutoMerge: last run blocked by comment and Override AutoMerge: ignore blocking comments labels #573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ericphanson
Copy link
Member

@ericphanson ericphanson commented Aug 7, 2024

This is the first RegistryCI feature that involves adding/removing labels programatically, as opposed to previous work that only reads them. This only affects the cron job. When it runs, it

  1. Checks if the label "AutoMerge: last run blocked by comment" exists. If not it creates it. This will require new permissions, so this change is likely breaking
  2. For each PR, if the PR has the label "Override AutoMerge: ignore blocking comments" then the PR does not count as blocked
  3. if a PR is blocked, the label "Override AutoMerge: ignore blocking comments" is added (again, this needs new permissions)
  4. if a PR is not blocked, the label "Override AutoMerge: ignore blocking comments" is removed (again, permissions)

Specifically, the permissions needed are: the github token by the cron job needs at least one of:

  • "Issues" repository permissions (write)
  • "Pull requests" repository permissions (write)

@DilumAluthge
Copy link
Member

Unit tests on Julia 1.3 should be fixed now after JuliaRegistries/General#112623. I'll retry that job.

@ericphanson
Copy link
Member Author

Is there a way to try the integration tests without merging?

@DilumAluthge
Copy link
Member

DilumAluthge commented Aug 8, 2024

We could add a workflow_dispatch trigger to the integration tests, which would allow us to trigger them manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants